Use 7999 as Bitbucket DC default port #4414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,6 +79,8 @@ void parseUnknownRemote(String cloneUrl, String expectedOrigin, String expectedP | |||
| [email protected]:stash/org/repo.git, scm.company.com/stash, Bitbucket, org/repo, org, repo | |||
| ssh://scm.company.com/stash/org/repo, scm.company.com/stash, Bitbucket, org/repo, org, repo | |||
| ssh://scm.company.com:22/stash/org/repo, scm.company.com/stash, Bitbucket, org/repo, org, repo | |||
| ssh://scm.company.com:22/stash/org/repo, scm.company.com:22/stash, Bitbucket, org/repo, org, repo | |||
| ssh://scm.company.com:7999/stash/org/repo, scm.company.com/stash, Bitbucket, org/repo, org, repo | |||
| ssh://scm.company.com:7999/stash/org/repo, scm.company.com:7999/stash, Bitbucket, org/repo, org, repo | |||
|
|
|||
There was a problem hiding this comment.
aren't these the same inputs? expected different results?
There was a problem hiding this comment.
no, the origin is both input and expected result
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Assume 7999 as a default SSH port for Bitbucket and strip it off. This way we can match the origin to the https origin (without port)
What's your motivation?
Currently when using the default port, we need to register 2 origins to make them both work. This can cause conflicts when switching between protocols.
Anyone you would like to review specifically?
@bryceatmoderne @kmccarp
Have you considered any alternatives or workarounds?
Not doing this
Checklist