Build GitRemote url from it's parts
#4411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a static method on `GitRemote` that can be used to create a `URI` from the required parts: ``` URI buildRemoteUrl(Service service, boolean ssh, String origin, String path) ```
shanman190
reviewed
Aug 14, 2024
shanman190
reviewed
Aug 14, 2024
pstreef
changed the title
GitRemote url from it's partsGitRemote url from it's parts
|
related: #4414 |
| BitbucketCloud, false, bitbucket.org, org/repo, https://bitbucket.org/org/repo | ||
| BitbucketCloud, true, bitbucket.org, org/repo, ssh://[email protected]/org/repo.git | ||
| Bitbucket, false, scm.company.com/context/path, org/repo, https://scm.company.com/context/path/scm/org/repo | ||
| Bitbucket, true, scm.company.com/context/path, org/repo, ssh://[email protected]/context/path/org/repo.git |
There was a problem hiding this comment.
Have we agreed on not adding the port 7999 to the ssh URL for Bitbucket?
There was a problem hiding this comment.
that is in a separate PR, but we probably need to decide that first: #4414
|
replaced by #4429 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Adds a static method on
GitRemotethat can be used to create aURIfrom the required parts:What's your motivation?
A single place to put this logic, which is the reverse of the URL parser that is already in
GitRemoteAnything in particular you'd like reviewers to focus on?
Are all these URI's (in the test) correct
Anyone you would like to review specifically?
@bryceatmoderne
Checklist