[MainUI] Update JS Scripting tern definitions #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference openhab/openhab-js#158. Reference openhab/openhab-js#175 (to be merged). Signed-off-by: Florian Hotze <[email protected]>
Reference openhab/openhab-js#160. Reference openhab/openhab-js#171. Reference https://github.com/openhab/openhab-js#createtimer. Signed-off-by: Florian Hotze <[email protected]>
Reference openhab/openhab-js#165. Signed-off-by: Florian Hotze <[email protected]>
Reference openhab/openhab-js#167. Signed-off-by: Florian Hotze <[email protected]>
Job #614: Bundle Size — 15.94MiB (~+0.01%).Metrics (no changes)
Total size by type (2 changes)
|
... as they are not used/referenced from the rest of the tern defs and not used in JS Scripting as well. Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
florian-h05
changed the title
|
@ghys This is ready for review now and should make it into 3.4.0! |
ghys
approved these changes
Dec 4, 2022
There was a problem hiding this comment.
Thanks, I suppose this susperses former submissions and apologies for the delay.
Having an autocompletion in the UI that matches what's available in the library is VERY important to me so I'm happy to merge this and let me know if there are last-minute things to improve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tern definitions are now up-to-date for version 3.0.0 of openhab-js.
Fixes #1550.
Description
The tern definitions for JS Scripting were updated in #1421 to address the openhab-js release 2.0.0.
Since then, we had numerous improvements and changes to the openhab-js library: openhab/openhab-js@v2.0.0...v3.0.0.
This updates the JS Scripting tern definitions:
ItemHistory: Add new methodsScriptExecution: RemovecreateTimerWithArgument& AddTimeractions: AddthingActionsTesting
I have tested it, all changes work fine.