-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[actions] Don't deprecate ScriptExecution.createTimer
#171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by using the thread-safe createTimer methods from the injected ThreadsafeTimers. Also remove the deprecation warning for createTimer and createTimerWithArgument. Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
@rkoshak Could you possibly review at least the README changes? |
digitaldan
approved these changes
Nov 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Florian Hotze <[email protected]>
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Nov 24, 2022
Reference openhab/openhab-js#160. Reference openhab/openhab-js#171. Reference https://github.com/openhab/openhab-js#createtimer. Signed-off-by: Florian Hotze <[email protected]>
florian-h05
added a commit
to florian-h05/openhab-rules-tools
that referenced
this pull request
Dec 16, 2022
Switch from the deprecated `actions.ScriptExecution.createTimerWithArgument` to ...`createTimer` to the threadsafe version. Reference openhab/openhab-js#171.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference https://community.openhab.org/t/js-scripting-why-are-we-deprecated-createtimer/140748.
Refercence openhab/openhab-addons#13695.
Description
This PR reverts the deprecation of
createTimer
from previous PR #169.As discussed on the forum https://community.openhab.org/t/js-scripting-why-are-we-deprecated-createtimer/140748, the setTimeout and setInterval methods do not provide the functionality that advanced users need, and to avoid that those users and users coming from Rules DSL leave JS Scripting because of a missing advanced timer creation API,
createTimer
is reimplemented to be thread-safe in openhab/openhab-addons#13695.createTimerWithArgument
is still deprecated, as there is no use case for it in JS (see openhab/openhab-addons#13695 (comment)).This PR is backward compatible and does not require the addon to be on the latest add-on version with the thread-safe reimplementation of
createTimer
, but keep in mind that if not, this can lead to multithread errors.Testing
Use the following file-based script: