-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to addon changes #169
Conversation
Reference openhab/openhab-addons#13582. Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
@digitaldan @jpg0 @rkoshak (sorry for pinging you all) Could any of you please review? |
I'm no JavaScript expert and not a maintainer of this repository, so I'm afraid I can't help much. When you have this PR reviewed and merged and a new lib is released, I'll of course help merging the new version into the addons repository. |
Signed-off-by: Florian Hotze <[email protected]>
You wouldn't be the first reviewer that is no maintainer, since we are only two maintainers and digitaldan is not always available when a time critic PR needs to be merged. I am aware that you are no JS expert, but it would be great if you could have a look at the README changes.
I will definitely come back to that offer! |
Fixes #168.
Changes
actions
: Log warning when the raw timer creation methods are accessedTesting
I have also verified that the library is still working under older versions of the addon that are running an older GraalJS and therefore NodeJS version.
Use the following script to verify all relevant changes: