Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JS Scripting tern definitions #1576

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Dec 11, 2022

Reference
openhab/openhab-js@v3.0.0...v3.1.2.
Last updates was in #1552.

Description

This updated the tern definitions for the current openhab-js version included in the addon (3.1.2).

The tern definitions for the cache namespace were updated to allow access to the shared and the private caches from core (see openhab/openhab-js#191).

For documentation of the cache, have a look at https://openhab.github.io/openhab-js/cache.html.

Testing

I need to check whether autocompletion for cache works correctly.

@ghys This should go into 3.4.0. Since the feature freeze is already active, this should get merged as bugfix.
It indeed fixes deprecation warnings that will be logged when someone tries to use something like cache.get() (which now would be cache.private.get() or cache.shared.get()).

This updated the tern definitions for the openhab-js version included
in the addon (3.1.2).
Reference
openhab/openhab-js@v3.0.0...v3.1.2.

Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 requested a review from a team as a code owner December 11, 2022 21:59
@relativeci
Copy link

relativeci bot commented Dec 11, 2022

Job #644: Bundle Size — 15.96MiB (-0.01%).

8169ad8(current) vs 46611af main#643(baseline)

Metrics (no changes)
                 Current
Job #644
     Baseline
Job #643
Initial JS 1.73MiB 1.73MiB
Initial CSS 608.3KiB 608.3KiB
Cache Invalidation 83.71% 83.71%
Chunks 218 218
Assets 688 688
Modules 2007 2007
Duplicate Modules 108 108
Duplicate Code 1.8% 1.8%
Packages 133 133
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #644
     Baseline
Job #643
CSS 856.34KiB 856.34KiB
Fonts 1.08MiB 1.08MiB
HTML 1.21KiB 1.21KiB
IMG 140.74KiB 140.74KiB
JS 9.03MiB (-0.02%) 9.03MiB
Media 295.6KiB 295.6KiB
Other 4.59MiB (~-0.01%) 4.59MiB

View job #644 reportView main branch activity

Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go into 3.4.0. Since the feature freeze is already active, this should get merged as bugfix.

Absolutely, feel free to submit any PR, the important thing is that the tern definitions match the library at release time.

@ghys ghys merged commit b4aff86 into openhab:main Dec 12, 2022
@florian-h05 florian-h05 deleted the update-jsscripting-tern-defs branch December 12, 2022 08:21
@florian-h05
Copy link
Contributor Author

You are absolutely right 👍

I think there should be more more changes in the library because the feature freeze is active and all changes that I have for the library are enhancements.

@ghys ghys changed the title [MainUI] Update JS Scripting tern definitions Update JS Scripting tern definitions Dec 12, 2022
florian-h05 added a commit to florian-h05/openhab-webui that referenced this pull request Feb 15, 2023
This updates the tern definitions for the current library version included in the addon (4.0.0).

Reference openhab/openhab-js@v3.1.2...v4.0.0.
Last update of tern defs was in openhab#1576.

Signed-off-by: Florian Hotze <[email protected]>
ghys pushed a commit that referenced this pull request Feb 16, 2023
This updates the tern definitions for the current library version
included in the addon (4.0.0).

Reference openhab/openhab-js@v3.1.2...v4.0.0.
Last update of tern defs was in #1576.

Signed-off-by: Florian Hotze <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants