Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed deprecated author information from bindings #1844

Merged
merged 3 commits into from
Nov 24, 2020

Conversation

kaikreuzer
Copy link
Member

This was discussed a long time ago and was planned for the start of openHAB 3 already - it fell of my plate somehow.

In short: Having a single author listed in this file does not make much sense for multiple reasons:

  • Bindings in the official repo are considered to be part of the openHAB project and not by an individual.
  • Many bindings have different contributors over the course of time, which isn't reflected here either.
  • The attribution of contributors is done within the source code.
  • We don't have this info for other types of add-on either.
  • Naming an author makes sense for marketplace entries, but for those we will anyhow have other metadata files.
  • The original purpose of this field was to give companies a possibility to "officially claim" a binding to be implemented and supported by them, but this actually never worked that way.

Signed-off-by: Kai Kreuzer [email protected]

@cweitkamp
Copy link
Contributor

I think we should go one step (or two steps) further. The OHC code does contain quite some test bundles which uses author-tags as well. They should be removed as a rolemodel. Furthermore we can think about removing it from the binding XSD. Another open question would be the BundingInfo and it's related DTO.

@kaikreuzer
Copy link
Member Author

Thanks - I fixed the itests.
Wrt the XSD and the related class/DTO: I didn't feel that this really justifies a breaking change in the schema (with all related efforts that come with that). I'd preferred a "smooth" phaseout by simply not using this "feature" anymore and thus considering it deprecated.
If you think it is cleaner to also adapt the XSD, let us do so as a second step.

@cweitkamp
Copy link
Contributor

Okay, just remove the tags from itest. As long as we do not touch the XSD we should keep the related test for parsing in place. this currently fails.

07:57:08.873 [main] DEBUG org.openhab.core.config.xml.osgi.XmlDocumentBundleTracker - Releasing the XmlDocumentProvider for module '@bundleId@0x2e'.
TEST org.openhab.core.binding.xml.test.BindingInfoTest#assertThatBindingInfoIsReadProperly() <<< ERROR: 
Expected: is "Deutsche Telekom AG"
     but: was null
java.lang.AssertionError: 
Expected: is "Deutsche Telekom AG"
     but: was null

Signed-off-by: Kai Kreuzer <[email protected]>
@kaikreuzer
Copy link
Member Author

Stupid me to also remove the entry from the test... Should be fixed now.

Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp merged commit 89767ce into openhab:master Nov 24, 2020
@wborn wborn added this to the 3.0.0.M4 milestone Nov 29, 2020
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
* removed deprecated author information from bindings
* removed author tag from itests

Signed-off-by: Kai Kreuzer <[email protected]>
GitOrigin-RevId: 89767ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants