-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed deprecated author information from bindings #1844
Conversation
Signed-off-by: Kai Kreuzer <[email protected]>
I think we should go one step (or two steps) further. The OHC code does contain quite some test bundles which uses author-tags as well. They should be removed as a rolemodel. Furthermore we can think about removing it from the binding XSD. Another open question would be the |
Signed-off-by: Kai Kreuzer <[email protected]>
Thanks - I fixed the itests. |
Okay, just remove the tags from itest. As long as we do not touch the XSD we should keep the related test for parsing in place. this currently fails.
|
Signed-off-by: Kai Kreuzer <[email protected]>
Stupid me to also remove the entry from the test... Should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
* removed deprecated author information from bindings * removed author tag from itests Signed-off-by: Kai Kreuzer <[email protected]> GitOrigin-RevId: 89767ce
This was discussed a long time ago and was planned for the start of openHAB 3 already - it fell of my plate somehow.
In short: Having a single author listed in this file does not make much sense for multiple reasons:
Signed-off-by: Kai Kreuzer [email protected]