[androiddebugbridge] initial contribution

[GiviMAD]

Signed-off-by: Miguel [email protected]

Hi openHAB community. I have created this binding to allow openHAB to connect to android devices using the adb protocol.
My motivation for this was to replace some adb commands that I was sending using the exec-binding (to an android device connected to my tv). With the binding I can also avoid to install de adb cli in the docker image and use the official image directly.
I also added some other channels like a player, a volume dimmer, and some to control the application opened. I've been using it for a couple of days and it seems to work correctly.
Hope it can be helpful for others.

[cweitkamp]

Thank you very much for your contribution. Will it be possible to control / connect to Fire TV Sticks by this binding? I would be very much interested in that feature.

[GiviMAD]

@cweitkamp. I'm happy to say it does :D , at least the Firestick 4k is the device that I'm using with the binding right now. Everything seems to work nicely unless the audio dimmer which I was not able to read/write from the adb. The audio dimmer works properly on the other device that I test with, my old nexus 5x.
As a comment maybe some improvements could be done on the DiscoveryService because the interface is not working correctly for me, I can't stop the search process. If you can give some advice on how to improve this I will be thankful.

[GiviMAD]

I can't find the build for this pr on the ci. I think there was some kind of error and it was not created. Can you trigger a rebuild? Thanks in advance.

[cweitkamp]

Can you trigger a rebuild? Thanks in advance.

Yes, of course. You can do that on your own by adding the "rebuild" label to your PR.

[fwolter]

Thanks for your contribution! I reviewed your code and here is my feedback.

[GiviMAD]

I think everything is done.
Also the build fails to queue again and I can't edit the pr labels, if no more changes are required can you trigger the build again? Thanks!

[fwolter]

LGTM

[cweitkamp]

I installed a version containing your latest changes and will check on the "state_dectection_rules". Thanks.

One thing which came up after a power loss of the Fire TV is a recurring warning in my logs. I am not sure why, but it looks like the binding cannot connect anymore.

2021-01-09 14:21:03.978 [WARN ] [mmon.WrappedScheduledExecutorService] - Scheduled runnable ended with an exception: 
java.lang.IllegalStateException: connect() must be called first
	at com.tananaev.adblib.AdbConnection.open(AdbConnection.java:321) ~[?:?]
	at org.openhab.binding.androiddebugbridge.internal.AndroidDebugBridgeDevice.lambda$0(AndroidDebugBridgeDevice.java:267) ~[?:?]
	at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) [?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) [?:?]
	at java.lang.Thread.run(Unknown Source) [?:?]
2021-01-09 14:21:03.986 [WARN ] [mmon.WrappedScheduledExecutorService] - Scheduled runnable ended with an exception: 
java.lang.IllegalStateException: connect() must be called first
	at com.tananaev.adblib.AdbConnection.open(AdbConnection.java:321) ~[?:?]
	at org.openhab.binding.androiddebugbridge.internal.AndroidDebugBridgeDevice.lambda$0(AndroidDebugBridgeDevice.java:267) ~[?:?]
	at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) [?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) [?:?]
	at java.lang.Thread.run(Unknown Source) [?:?]
2021-01-09 14:21:03.994 [WARN ] [mmon.WrappedScheduledExecutorService] - Scheduled runnable ended with an exception: 
java.lang.IllegalStateException: connect() must be called first
	at com.tananaev.adblib.AdbConnection.open(AdbConnection.java:321) ~[?:?]
	at org.openhab.binding.androiddebugbridge.internal.AndroidDebugBridgeDevice.lambda$0(AndroidDebugBridgeDevice.java:267) ~[?:?]
	at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) [?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) [?:?]
	at java.lang.Thread.run(Unknown Source) [?:?]
2021-01-09 14:21:04.002 [WARN ] [mmon.WrappedScheduledExecutorService] - Scheduled runnable ended with an exception: 
java.lang.IllegalStateException: connect() must be called first
	at com.tananaev.adblib.AdbConnection.open(AdbConnection.java:321) ~[?:?]
	at org.openhab.binding.androiddebugbridge.internal.AndroidDebugBridgeDevice.lambda$0(AndroidDebugBridgeDevice.java:267) ~[?:?]
	at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) [?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) [?:?]
	at java.lang.Thread.run(Unknown Source) [?:?]

[GiviMAD]

Now the thing connect again correctly. Thanks for pointing that.

[cweitkamp]

Sry, I did non come back to you earlier. The latest version from last Sunday looks better. But can still see a warning in my logs when the binding tries to reconnect. I this situation my Fire TV Stick is in standby mode. Unfortunately it does not help to wake it up. I have to perform a full restart of the Fire TV Stick to establish a working connection again.

2021-01-17 15:59:20.441 [WARN ] [mmon.WrappedScheduledExecutorService] - Scheduled runnable ended with an exception: 
java.lang.IllegalStateException: connect() must be called first
	at com.tananaev.adblib.AdbConnection.open(AdbConnection.java:321) ~[?:?]
	at org.openhab.binding.androiddebugbridge.internal.AndroidDebugBridgeDevice.lambda$0(AndroidDebugBridgeDevice.java:271) ~[?:?]
	at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) [?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) [?:?]
	at java.lang.Thread.run(Unknown Source) [?:?]

[cweitkamp]

some minor improvements

[GiviMAD]

I can't get rid of the warning in the logs because the library close the connection once the fire stick is offline and I not able to detect this until it throws that exception. Once it throws the binding should change the thing state to offline and the warning should stop spamming.
I'll try to make a pr to the library to improve this in a future update but at the moment I couldn't get anything better or at least did manage to do it.
Let me know if more improvements are required and thanks for the feedback.

[cweitkamp]

Thanks for your patience. I am fine with the current implementation. Improvements and new features can be added later.

Only two final comments because I recognized it in the latest commit. First one is inline. Second one - please review the code of the AndroidDebugBridgeHandler class because there are some if-statements without curly brackets.

I am done. 😉

[cweitkamp]

LGTM. Thanks.

@cpmeister Are all your comments addressed?