Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[generacmobilelink] Initial Contribution #9322

Merged
merged 16 commits into from
Dec 28, 2020
Merged

[generacmobilelink] Initial Contribution #9322

merged 16 commits into from
Dec 28, 2020

Conversation

digitaldan
Copy link
Contributor

This is the initial contribution of the Generac MobileLink binding. This allows the Generac line of generators using their MobileLink cloud service to be monitored as things in openHAB.

@digitaldan digitaldan requested a review from a team as a code owner December 10, 2020 20:02
@fwolter fwolter added the new binding If someone has started to work on a binding. For a new binding PR. label Dec 10, 2020
@mhilbush
Copy link
Contributor

Very cool! I finally might have a reason to get MobileLink on my standby generator.

@digitaldan
Copy link
Contributor Author

Happy to hear someone else might find this useful then!

fwolter
fwolter requested changes Dec 15, 2020
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I reviewed your code and here is my feedback.

There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html.

bundles/org.openhab.binding.generacmobilelink/README.md Show resolved Hide resolved
bundles/org.openhab.binding.generacmobilelink/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.generacmobilelink/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.generacmobilelink/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.generacmobilelink/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.generacmobilelink/src/main/resources/OH-INF/binding/binding.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.generacmobilelink/src/main/resources/OH-INF/binding/binding.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.generacmobilelink/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.generacmobilelink/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.generacmobilelink/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
@fwolter fwolter self-assigned this Dec 15, 2020
@digitaldan
Copy link
Contributor Author

Thanks @fwolter for reviewing ! I have finished addressing your comments.

fwolter
fwolter approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fwolter fwolter added the cre Coordinated Review Effort label Dec 18, 2020
@fwolter fwolter removed their assignment Dec 18, 2020
@digitaldan
Copy link
Contributor Author

digitaldan commented Dec 18, 2020 •
edited
Loading

Hi @fwolter sorry for the last min commit. I had a cheap hack to get around the API returning a 401 without the correct headers that caused the synchronous use of jetty (which most of us use) to throw a generic execution exception. I was basically parsing the exception message for specific string since i did not have a response code at that point. This worked, but was bothering me :-)

I implemented this again using the asynchronous version along with a compatible future which allows me to properly catch this condition.

@digitaldan
Copy link
Contributor Author

Thanks for the feedback @cpmeister ! I have addressed your comments in the latest commit.

cpmeister
cpmeister requested changes Dec 24, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what little I know about generators, I know that they must be run periodically as part of their maintenance. Is it possible through the mobile link to turn on/off the generator remotely so that such maintenance is scheduled through openHAB?

.../org/openhab/binding/generacmobilelink/internal/handler/GeneracMobileLinkAccountHandler.java Outdated Show resolved Hide resolved
.../org/openhab/binding/generacmobilelink/internal/handler/GeneracMobileLinkAccountHandler.java Outdated Show resolved Hide resolved
bundles/org.openhab.binding.generacmobilelink/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
@digitaldan
Copy link
Contributor Author

I have addressed your comments in my latest commit, thanks.

From what little I know about generators, I know that they must be run periodically as part of their maintenance. Is it possible through the mobile link to turn on/off the generator remotely so that such maintenance is scheduled through openHAB?

The API allows for read only access, their mobile client is read only as well.

@digitaldan
This is the initial contribution of the Generac MobileLink binding. T…
86cd3bf 
…his allows the Generac line of generators using their MobileLink cloud service to be monitored as things in openHAB.

Signed-off-by: Dan Cunningham <[email protected]>
@digitaldan
Fix config name case for consistancy.
facc963 
Signed-off-by: Dan Cunningham <[email protected]>
@digitaldan
Address feedback comments, add simple retry to status request, catch …
abbe25e 
…specific error from jetty

Signed-off-by: Dan Cunningham <[email protected]>
@digitaldan
added code check fixes, null checks
93963a2 
Signed-off-by: Dan Cunningham <[email protected]>
@digitaldan
small readme formatting
ea3c5ec 
Signed-off-by: Dan Cunningham <[email protected]>
@digitaldan
another small readme fix
a3646c9 
Signed-off-by: Dan Cunningham <[email protected]>
@digitaldan
Move api package to DTO structure to avoid checkstyle warnings
76421e5 
Signed-off-by: Dan Cunningham <[email protected]>
@digitaldan
Remove discovery debugging logging
a763ce0 
Signed-off-by: Dan Cunningham <[email protected]>
@digitaldan
Removed logging, smal config refactoring
3be5122 
Signed-off-by: Dan Cunningham <[email protected]>
@digitaldan
removing logging
491ff60 
Signed-off-by: Dan Cunningham <[email protected]>
@digitaldan
Use async jetty to catch 401 errors from the API service
0bdb74c 
Signed-off-by: Dan Cunningham <[email protected]>
@digitaldan
last cleanup of unused logger and comment update
823a410 
Signed-off-by: Dan Cunningham <[email protected]>
@digitaldan
Simplify connection handling, PR review changes.
e90a131 
Signed-off-by: Dan Cunningham <[email protected]>
@digitaldan
remove debug statement
115eb30 
Signed-off-by: Dan Cunningham <[email protected]>
@digitaldan
Addressed feedback
9b93c3a 
Signed-off-by: Dan Cunningham <[email protected]>
@digitaldan
bump to 3.1
3e54836 
Signed-off-by: Dan Cunningham <[email protected]>
@digitaldan
Copy link
Contributor Author

Updated for 3.1.0-snapshot

@cpmeister cpmeister added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Dec 27, 2020
@cpmeister cpmeister merged commit 6cb9f3a into openhab:main Dec 28, 2020
@cpmeister cpmeister added this to the 3.1 milestone Dec 28, 2020
seaside1 pushed a commit to seaside1/openhab-addons that referenced this pull request Dec 28, 2020
@digitaldan @seaside1
[generacmobilelink| Initial Contribution (openhab#9322)
e0ec769 
* This is the initial contribution of the Generac MobileLink binding.  This allows the  Generac line of generators using their MobileLink cloud service to be monitored as things in openHAB.
* bump to 3.1

Signed-off-by: Dan Cunningham <[email protected]>
seaside1 pushed a commit to seaside1/openhab-addons that referenced this pull request Dec 28, 2020
@digitaldan @seaside1
[generacmobilelink| Initial Contribution (openhab#9322)
a6f8573 
* This is the initial contribution of the Generac MobileLink binding.  This allows the  Generac line of generators using their MobileLink cloud service to be monitored as things in openHAB.
* bump to 3.1

Signed-off-by: Dan Cunningham <[email protected]>
Signed-off-by: Joseph Hagberg <[email protected]>
@kaikreuzer kaikreuzer changed the title [generacmobilelink| Initial Contribution [generacmobilelink] Initial Contribution Jan 31, 2021
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@digitaldan @thinkingstone
[generacmobilelink| Initial Contribution (openhab#9322)
5ff11a4 
* This is the initial contribution of the Generac MobileLink binding.  This allows the  Generac line of generators using their MobileLink cloud service to be monitored as things in openHAB.
* bump to 3.1

Signed-off-by: Dan Cunningham <[email protected]>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@digitaldan
[generacmobilelink| Initial Contribution (openhab#9322)
7c5947b 
* This is the initial contribution of the Generac MobileLink binding.  This allows the  Generac line of generators using their MobileLink cloud service to be monitored as things in openHAB.
* bump to 3.1

Signed-off-by: Dan Cunningham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwolter fwolter fwolter approved these changes

@cpmeister cpmeister cpmeister approved these changes

Assignees
No one assigned
Labels
cre Coordinated Review Effort new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@digitaldan @mhilbush @cpmeister @fwolter