Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: release v6.166.0 #7960

Closed
wants to merge 4 commits into from
Closed

build: release v6.166.0 #7960

wants to merge 4 commits into from

Conversation

kevin9foong
Copy link
Contributor

New

  • feat(twilio): remove twilio be #7870
  • feat: update form create modal response options #7957
  • chore: include latest features in whats new page #7956
  • feat(mrf): conditional routing #7804
  • fix: trim text input before sending to backend #7937
  • test(story): add chromatic story to ensure thankyou page renders #7264
  • chore: remove unused deps #7906
  • feat(i18n): extract text from admin-form prompts #7931
  • chore(FE): cleanup date check on sex field #7922
  • chore(FE): use consistent vite port for dev with README #7930
  • feat(i18n): move workspace relative date format #7929
  • build: release v6.165.0 #7928
  • build: release v6.165.0 #7927
  • feat(i18n): extract text for form metadata #7926
  • chore: bump version to v6.166.0 c51e807

Dependencies

  • fix(deps): bump libphonenumber-js from 1.11.14 to 1.11.15 in /shared #7936

Dev-Dependencies

  • chore(deps-dev): bump @playwright/test from 1.45.1 to 1.49.0 #7923

Tests

feat(twilio): remove twilio be #7870

Regression

Admin able to create form
  • Create a storage mode form
  • Add mobile number field, enable OTP verification
  • Ensure that mobile number field can be saved
Respondent can submit a mobile number field with OTP
  • Verify mobile number OTP
  • Ensure that a mobile number OTP is sent to your number
  • Ensure that field can be verified
  • Ensure that form can be submitted

feat(mrf): conditional routing #7804

TC1: Conditional routing works for single email per option and multiple emails per option

  • Create an mrf form.
  • Create a second step and set the 2nd step respondent to conditional routing.
  • Update the 2nd step options to emails mapping
  • Select a dropdown field (with >= 3 options) and upload a valid options to emails mapping (try 1 option to multiple emails in the csv, specifically, 1 option to 1 email field, 1 option to 2 email fields and 1 option to 3 email fields). Ensure this dropdown field is assigned to step 1 for editing.
  • Try to download the csv mapping from step 2 edit page after uploading the csv. Ensure that the downloaded csv displays the same options to mapping as what was uploaded.
  • Add a third step with respondent set to dynamic aka email field.
  • Make the form public
  • Submit and complete all workflow steps
  • Ensure the email recipient for each step is correct (eg, sends to correct email specified in uploaded csv file based on dropdown field selected)
  • Repeat submitting through the steps for all the options of the conditional field to check next step email is sent to the correct email recipient.

TC2: Selecting same dropdown field for multiple conditional routing steps

  • Continue from TC1.
  • Update step 3 respondent to conditional routing. Choose the same dropdown field as step 2.
  • Ensure the options to email mappings already exists and dont need to upload.
  • Try to submit all steps of the form. Ensure that the next step emails are sent to the correct email recipients based on the dropdown options selected in the submission response.

TC3: Email notifications work with conditional routing

  • Continue from TC2.
  • Enable email notifications for the MRF form and set step 2 to receive email notifications.
  • Complete the workflow and ensure that the email recipient based on the option for dropdown field for step 2 receives the outcome email.

TC4: Deleting the dropdown field options to email mapping shows error message

  • Continue from TC3
  • Delete the emails to options mapping by editing step 2 of the workflow.
  • Change step 2 to static / fixed email respondent and save.
  • Ensure that step 3 now shows an error message in the inactive state of the workflow builder.
  • Try to submit all steps of the form without updating step 3.
  • Assert that no next step email is sent for step 3.

TC5: Uploading invalid options

  • Continue from TC4.
  • Go to edit step 3 in the workflow builder.
  • Try to upload a options to email csv which contains missing options compared to the selected field options.
  • Assert an error is displayed and cannot upload.
  • Try to upload csv which contains duplicate options rows.
  • Assert an error is displayed and cannot upload.
  • Try to upload csv which have a row with missing options col but filled emails col.
  • Assert an error is displayed and cannot upload.
  • Try to upload csv which have a row with missing email col but filled options col.
  • Assert an error is displayed and cannot upload.
  • Try to upload csv which has email that is not valid eg, abc in email col
  • Assert an error is displayed and cannot upload.

chore: remove unused deps #7906

Regression

Landing page renders
  • Ensure that landing page renders

chore: bump version to v6.166.0 c51e807

feat(mrf): conditional routing #7804

TC1: Conditional routing works for single email per option and multiple emails per option

  • Create an mrf form.
  • Create a second step and set the 2nd step respondent to conditional routing.
  • Update the 2nd step options to emails mapping
  • Select a dropdown field (with >= 3 options) and upload a valid options to emails mapping (try 1 option to multiple emails in the csv, specifically, 1 option to 1 email field, 1 option to 2 email fields and 1 option to 3 email fields). Ensure this dropdown field is assigned to step 1 for editing.
  • Try to download the csv mapping from step 2 edit page after uploading the csv. Ensure that the downloaded csv displays the same options to mapping as what was uploaded.
  • Add a third step with respondent set to dynamic aka email field.
  • Make the form public
  • Submit and complete all workflow steps
  • Ensure the email recipient for each step is correct (eg, sends to correct email specified in uploaded csv file based on dropdown field selected)
  • Repeat submitting through the steps for all the options of the conditional field to check next step email is sent to the correct email recipient.

TC2: Selecting same dropdown field for multiple conditional routing steps

  • Continue from TC1.
  • Update step 3 respondent to conditional routing. Choose the same dropdown field as step 2.
  • Ensure the options to email mappings already exists and dont need to upload.
  • Try to submit all steps of the form. Ensure that the next step emails are sent to the correct email recipients based on the dropdown options selected in the submission response.

TC3: Email notifications work with conditional routing

  • Continue from TC2.
  • Enable email notifications for the MRF form and set step 2 to receive email notifications.
  • Complete the workflow and ensure that the email recipient based on the option for dropdown field for step 2 receives the outcome email.

TC4: Deleting the dropdown field options to email mapping shows error message

  • Continue from TC3
  • Delete the emails to options mapping by editing step 2 of the workflow.
  • Change step 2 to static / fixed email respondent and save.
  • Ensure that step 3 now shows an error message in the inactive state of the workflow builder.
  • Try to submit all steps of the form without updating step 3.
  • Assert that no next step email is sent for step 3.

TC5: Uploading invalid options

  • Continue from TC4.
  • Go to edit step 3 in the workflow builder.
  • Try to upload a options to email csv which contains missing options compared to the selected field options.
  • Assert an error is displayed and cannot upload.
  • Try to upload csv which contains duplicate options rows.
  • Assert an error is displayed and cannot upload.
  • Try to upload csv which have a row with missing options col but filled emails col.
  • Assert an error is displayed and cannot upload.
  • Try to upload csv which have a row with missing email col but filled options col.
  • Assert an error is displayed and cannot upload.
  • Try to upload csv which has email that is not valid eg, abc in email col
  • Assert an error is displayed and cannot upload.
chore: remove unused deps #7906

Regression
######## Landing page renders

  • Ensure that landing page renders

kevin9foong and others added 4 commits November 29, 2024 14:58
@kevin9foong
chore: include latest features in whats new page (#7956)
d533ed2 
* feat: update whatsnew with new MRF features

* feat: update copy for whatsnew

* feat: update copy
@kevin9foong
feat: update form create modal response options (#7957)
3be7636 
* feat: update form create modal response options

* feat: move tile back

* feat: move tiling for email mode to rightmost
@KenLSM @kevin9foong
feat(twilio): remove twilio be (#7870)
a0f1a15 
* feat: remove twilio from fe

* chore: restore shared files as they are used by BE

* feat: remove twilio from be pass 1

* test: verification.service.spec.ts

* test: admin-form.service.spec.ts

* fix: remove deleted files

* fix: lint issues

* fix: verification routes

* chore: fix lint errors

* Revert "chore: restore shared files as they are used by BE"

This reverts commit bc8ee76.

* feat: remove twilio verifications

* chore: fix lint issues

* chore: remove retrievePublicFormsWithSmsVerification func

* chore: fix lint issues

* feat: remove get/set for msgSrvcName, remove aws ssm

* chore: remove stoplight/prism

* feat: remove twilioCredentials from i18n

* feat: remove msgSrvcName

* chore: document msgSrvcName in code

* fix: remove unused import

* feat: update docs to mark msgSrvcName as legacy

---------

Co-authored-by: Kevin Foong <[email protected]>
@kevin9foong
chore: bump version to v6.166.0
3cd806a
@kevin9foong kevin9foong closed this Dec 2, 2024
@KenLSM KenLSM deleted the release_v6.166.0 branch December 10, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevin9foong @KenLSM