Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(FE): cleanup date check on sex field #7922

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Nov 19, 2024

Problem

Date check was implemented on Sex field to support switch overs on a particular date. Since the date has already passed, there is no longer a need for us to check the date.

Closes FRM-1741

Solution

Remove Infoboxes and permanently change update gender -> sex.

Breaking Changes

  • No - this PR is backwards compatible

Copy link

linear bot commented Nov 19, 2024

@KenLSM KenLSM changed the title chore(FE): remove date checking code chore(FE): cleanup date check on sex field Nov 20, 2024
Copy link
Contributor

@kevin9foong kevin9foong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KenLSM KenLSM merged commit a8ff492 into develop Nov 20, 2024
27 checks passed
@KenLSM KenLSM deleted the chore/remove-old-code branch November 20, 2024 11:26
This was referenced Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants