Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(FE): use consistent vite port for dev with README #7930

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

littlemight
Copy link
Collaborator

@littlemight littlemight commented Nov 20, 2024

Problem

Frontend dev start script uses vite's default 5173 port, while README states 3000 as FE port.
Not touching vite.config.ts, afraid it might impact github job + deployment scripts.

Solution

Update README to reflect the vite's port.

Breaking Changes

  • No - this PR is backwards compatible

@KenLSM
Copy link
Contributor

KenLSM commented Nov 20, 2024

@littlemight could we update the readme instead? Thinking that it would be easier and straightforward to follow the standard vite default port 5173.

Appreciate the help on keeping our README up to date!

@littlemight littlemight marked this pull request as ready for review November 20, 2024 07:09
@littlemight littlemight requested a review from KenLSM November 20, 2024 07:09
Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KenLSM KenLSM merged commit a86c729 into develop Nov 20, 2024
17 checks passed
@KenLSM KenLSM deleted the chore/fe-vite-port branch November 20, 2024 11:26
@KenLSM KenLSM mentioned this pull request Nov 21, 2024
1 task
This was referenced Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants