Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: release v6.163.0 #7914

Merged
merged 10 commits into from
Nov 19, 2024
Merged

build: release v6.163.0 #7914

merged 10 commits into from
Nov 19, 2024

Conversation

kevin9foong
Copy link
Contributor

@kevin9foong kevin9foong commented Nov 19, 2024 •
edited
Loading

New

  • feat: switch delete to edit button on logic page #7887
  • fix: replace Question with Field Name for relevant fields in FieldBuilder #7901
  • fix(mrf be val): skip validation for unchanged mrf responses #7894
  • feat(mrf-approvals): improve copy for approvals #7902
  • feat: unify email notification for response copy for storage and email modes #7903
  • fix(mail): failure to render mail #7890
  • chore: update package-lock #7907
  • build: merge release v6.162.0 to develop #7904
  • build: release v6.162.0 #7897
  • chore: remove jest-axios-mock, jest-localstorage-mock #7893

Dependencies

  • fix(deps): bump nodemailer and @types/nodemailer #7891
  • fix(deps): bump express-rate-limit from 7.4.0 to 7.4.1 #7892

Dev-Dependencies

  • chore(deps-dev): bump lint-staged from 15.2.7 to 15.2.10 #7899

Tests

feat: switch delete to edit button on logic page #7887

Regression

Edit logic can be triggered
  • Add a "number field" and a "text field"
  • Create a logic with "number field" as logic predicate, and show "text field" as outcome
  • Press "Save changes"
  • Ensure that the <PencilIcon /> can be clicked
  • Ensure that clicking on areas that are not part of <PencilIcon /> does not enter edit mode
Editing another input should not be allowed if already in edit mode
  • Create another logic with "number field" as logic predicate, and show "text field" as outcome
  • Press "Save changes"
  • Click on <PencilIcon /> to enter edit mode
  • Ensure that clicking on another logic step does not enter edit mode and onhover cursor is represented with "not-allowed"

@scottheng96 testing

fix(mail): failure to render mail #7890

Bounced emails are triggered
  • Create an email mode form
  • Set email recipients only contain invalid emails
  • Open the form
  • Submit the form
  • Ensure that you receive a bounced email as the form owner

KenLSM and others added 10 commits November 18, 2024 15:04
@KenLSM
Merge pull request #7904 from opengovsg/release-al2
6e45a80 
build: merge release v6.162.0 to develop
@kevin9foong
feat: unify email notification for response copy for storage and emai…
29bed84 
…l modes (#7903)

* feat: update email notif copy for storage and email mode

* feat: update copy for create email modal notification input
@kevin9foong
feat(mrf-approvals): improve copy for approvals (#7902)
621bf76 
* fix: update fixed email copy to specific email

* fix: remove tooltip from steplabel step 1

* feat: remove header for approvals and add tooltip to toggle

* feat: improve aria label for tooltip

* fix: set field edit selection header to h4

* fix: update interaction tests in stories to reference new copy

* fix: update header and helper text to follow figma

* feat: change approvals inactive header state
@kevin9foong @KenLSM
fix(mrf be val): skip validation for unchanged mrf responses (#7894)
d5a4bae 
* feat: add more specific logs for date validation failures

* feat: remove validation for unchanged mrf responses

* feat: refactor isChanged to its own util to be testable, add tc

* fix: change shared import to relative

* chore: wrap case body in scope to remove disable-eslint lines

---------

Co-authored-by: Ken <[email protected]>
@scottheng96
fix: replace Question with Field Name for relevant fields in FieldBui…
c01fdd4 
…lder (#7901)

* replace Question with Field Name for relevant fields

* update e2e tests
@KenLSM
feat: switch delete to edit button on logic page (#7887)
428d7aa
@dependabot
chore(deps-dev): bump lint-staged from 15.2.7 to 15.2.10 (#7899)
4471b30 
Bumps [lint-staged](https://github.com/lint-staged/lint-staged) from 15.2.7 to 15.2.10.
- [Release notes](https://github.com/lint-staged/lint-staged/releases)
- [Changelog](https://github.com/lint-staged/lint-staged/blob/master/CHANGELOG.md)
- [Commits](lint-staged/lint-staged@v15.2.7...v15.2.10)

---
updated-dependencies:
- dependency-name: lint-staged
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump nodemailer and @types/nodemailer (#7891)
f3a4b62 
Bumps [nodemailer](https://github.com/nodemailer/nodemailer) and [@types/nodemailer](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/nodemailer). These dependencies needed to be updated together.

Updates `nodemailer` from 6.9.13 to 6.9.16
- [Release notes](https://github.com/nodemailer/nodemailer/releases)
- [Changelog](https://github.com/nodemailer/nodemailer/blob/master/CHANGELOG.md)
- [Commits](nodemailer/nodemailer@v6.9.13...v6.9.16)

Updates `@types/nodemailer` from 6.4.15 to 6.4.16
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/nodemailer)

---
updated-dependencies:
- dependency-name: nodemailer
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: "@types/nodemailer"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@KenLSM
chore: update package-lock (#7907)
65160dd
@kevin9foong
chore: bump version to v6.163.0
7fa5e57
@datadog-opengovsg
Copy link

Datadog Report

Branch report: release_v6.163.0
Commit report: 7fa5e57
Test service: formsg

✅ 0 Failed, 1285 Passed, 1 Skipped, 2m 24.14s Total duration (4m 38.95s time saved)

@kevin9foong
Copy link
Contributor Author

Validated that bounced emails are received
image

@kevin9foong kevin9foong merged commit 5e3da62 into release-al2 Nov 19, 2024
59 of 62 checks passed
@kevin9foong kevin9foong deleted the release_v6.163.0 branch November 19, 2024 01:36
@kevin9foong kevin9foong mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottheng96 scottheng96 scottheng96 approved these changes

@KenLSM KenLSM Awaiting requested review from KenLSM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevin9foong @scottheng96 @KenLSM