feat(mrf-approvals): improve copy for approvals #7902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin9foong
commented
Nov 18, 2024
| @@ -92,7 +92,7 @@ export const FormLabel = ({ | |||
| <Tooltip | |||
| placement={tooltipPlacement} | |||
| label={tooltipText} | |||
| aria-label="Label tooltip" | |||
| aria-label={`Tooltip content: ${tooltipText}`} | |||
There was a problem hiding this comment.
changed to improve screen reader output to include tooltip text
kevin9foong
commented
Nov 18, 2024
| <FormLabel.Label sx={{ ...styles.label, ...labelStyles }}> | ||
| {label} | ||
| </FormLabel.Label> | ||
| <Flex alignItems="center"> |
There was a problem hiding this comment.
no / minimal changes to previous usages of Tooltip expected
Rationale:
- flex direction is row, with no changes to the main axis orientation
- tooltipText is checked before adding another component. since prev usages do not pass in tooltipText, they should remain unchanged
kevin9foong
commented
Nov 18, 2024
frontend/src/features/admin-form/create/workflow/components/WorkflowContent/StepLabel.tsx
Show resolved
Hide resolved
kevin9foong
changed the title
kevin9foong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some P1 improvements to the copy are requested to improve admin understandability for MRF Approvals.
Closes FRM-1910
Solution
Make the necessary changes according to the Figma.
Additional changes to aria-label for tooltip in
FormLabelandTogglecomponents have been fixed for better screen reader accessibility. Previously, screen readers would just read tooltip label without reading the content of the tooltip.Breaking Changes