Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unify email notification for response copy for storage and email modes #7903

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

kevin9foong
Copy link
Contributor

@kevin9foong kevin9foong commented Nov 18, 2024

Problem

The copy for the same functionality (email notifications for responses) on email and storage mode differ.

Closes FRM-1911

Solution

Make the copy the same for both modes.

Breaking Changes

  • No - this PR is backwards compatible

@kevin9foong kevin9foong requested a review from KenLSM November 18, 2024 04:32
Copy link

linear bot commented Nov 18, 2024

@kevin9foong kevin9foong self-assigned this Nov 18, 2024
@kevin9foong kevin9foong changed the title feat: email notif copy unification for storage and email modes feat: unify email notification for response copy for storage and email modes Nov 18, 2024
@datadog-opengovsg
Copy link

Datadog Report

Branch report: feat/email-notif-copy
Commit report: 4372b58
Test service: formsg

✅ 0 Failed, 1375 Passed, 1 Skipped, 3m 56.59s Total duration (2m 3.94s time saved)

Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevin9foong kevin9foong merged commit 29bed84 into develop Nov 18, 2024
27 checks passed
@kevin9foong kevin9foong deleted the feat/email-notif-copy branch November 18, 2024 08:24
@kevin9foong kevin9foong mentioned this pull request Nov 19, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants