build: release v6.149.0

[kevin9foong]

New

• build: merge release v6.148.0 to develop #7724
• feat: approvals for mrf #7636
• fix: coverall allow empty lcov #7722
• chore: remove p-queue from be #7693
• chore: add comments clarifying potentially confusing terms #7694
• ci(Mergify): configuration update #7720
• chore: Revert "chore(deps-dev): bump jest-environment-jsdom from 29.5.0 to 29.7.0" #7719
• feat(tracking): mrf workflow + creation #7704
• chore: remove unused deps #7685
• fix: chromatic build failure #7684
• build: release v6.148.0 #7683

Dependencies

• fix(deps): bump libphonenumber-js from 1.11.8 to 1.11.9 in /shared #7713
• fix(deps): bump express-rate-limit from 7.2.0 to 7.4.0 #7710
• fix(deps): bump aws-sdk from 2.1659.0 to 2.1691.0 #7703
• fix(deps): jest extended upgrade to 4.0.2 #7698
• fix(deps): bump dotenv from 16.0.3 to 16.4.5 #7702
• fix(deps): bump @aws-sdk/client-lambda from 3.414.0 to 3.654.0 #7701
• fix(deps): bump axios from 1.7.4 to 1.7.7 #7699
• fix(deps): bump opossum and @types/opossum #7593
• fix(deps): bump neverthrow from 6.1.0 to 8.0.0 #7697
• fix(deps): bump @opengovsg/sgid-client from 2.0.0 to 2.2.0 #7687

Dev-Dependencies

• chore(deps-dev): bump @types/lodash from 4.17.7 to 4.17.9 in /shared #7717
• chore(deps-dev): bump @babel/preset-env from 7.25.3 to 7.25.4 #7711
• chore(deps-dev): bump @types/busboy from 1.5.3 to 1.5.4 #7709
• chore(deps-dev): bump @stoplight/prism-cli from 5.5.4 to 5.10.0 #7708
• chore(deps-dev): bump jest-environment-jsdom from 29.5.0 to 29.7.0 #7707
• chore(deps-dev): bump eslint-plugin-prettier from 5.1.3 to 5.2.1 #7706
• chore(deps-dev): bump @types/dedent from 0.7.0 to 0.7.2 #7696

Tests

feat(tracking): mrf workflow + creation #7704

@kevin9foong
Regression
Workflow can be added

• Create an MRF
• Add an email field
• Click on Add Workflow
• Assign email field to Step 1
• Ensure that Step 1 "Save field" saves
• Assign email field to Step 2
• Ensure that Step 2 "Save field" saves

feat: approvals for mrf #7636

@KenLSM

For approvals:
Test set up:

• Create an MRF form called 'finance claims approval'
• Add 2 approval yes/no fields named 'RO approve', 'Finance dept approve'. Assert that Use for approvals badge appears beside yes/no fields in drawer.
• Add 2 email fields
• Assign 1 email field to step 1 to edit, Assign approval field to step 2 to edit and Assign approval field to step 3 to edit. (do not assign approval field or step 1 email notification field yet)
• Let step 2 be static email, let step 3 be dynamic email field

TC1: Regression test - MRF still works

• Open the form to public
• Respond to form, ensure that all steps of mrf can be completed and result is in admin responses tab.
• Assert no email outcomes are sent, since not yet configured in email notification settings.

TC2: Regression test - email notif works:

• From TC1, config email notif setting to step 2 and static email of choice.
• Complete submission, assert that workflow completed (note that it is not an outcome status email) is sent to expected emails.
• Remove the email notifs to prepare for TC3.

TC3: Approve without email notif. Expect no email sent

• Assign approval field to step 2 only.
• Complete all 3 steps of mrf workflow and approve at step 2.
• No email is sent.

TC4: Reject without email notif. Expect no email sent

• Use same form from TC3
• Reject at step 2 of mrf workflow.
• No email is sent to step 3 respondent since workflow ends, no outcome email is sent.

TC5: Approve and reject with email notification works:

• Add step 1 and step 3 to email notification and a static email to email notification.
• Repeat TC3. Assert that only email from step 3 and static email receives approve email, since step 1 does not have email field setup.
• Add email field to step 1 in workflow.
• Repeat TC4. Assert step 1 and step 3 and static email receive "Not approved" email.

TC6: Multiple approval steps - approve all

• From TC5, add approval step for step 3 of workflow.
• Approve all approval steps, approve email should be received.

TC7: Multiple approval steps - Reject at step 2 (middle step)

• From TC6, make submission
• Reject at step 2, assert R3 does not receive email and "Not approved" email is sent to emails in the email notification fields.

TC8: Multiple approval steps - Reject at last step

• From TC7, make submission
• Approve at step 2 but Reject at step 3, assert "Not approved" email is sent to all emails in the email notification fields.

Edge cases:
TC10: approval field set to optional, respondent did not fill

• From TC9, set the approval field used for step 2 as optional.
• Try and submit the steps of form, but at step 2, do not fill in the optional approval field.
• assert that R3 no longer gets the next step email, no completion/approval outcome emails are sent.
• Visit the responses page, the R2 submission is recorded.
• Share the next step response link, it goes to R3 and can be resumed.
• Try and submit R3 and approve/reject, it should send out approved/reject email to expected emails.

TC10: approval field deleted, admin did not reassign

• From TC9, delete the approval field used for step 2.
• Try and submit the steps of the form.
• assert that R3 no longer gets the next step email, no completion/approval outcome emails are sent.
• Visit the responses page, the R2 submission is recorded.
• Share the next step response link, it goes to R3 and can be resumed.
• Try and submit R3 and approve/reject, it should send out approved/reject email to expected emails.

[KenLSM]

Unsure what does "expected" here means. Briefly checked the PRD, but it also doesn't fully ascribe who is expected

TC7:

• Reject at step 2, assert R3 does not receive email and "Not approved" email is sent to expected emails.

R3 receives “Outcome email, but NOT “Request for approval email”

TC7:

• Approve at step 2 but Reject at step 3, assert "Not approved" email is sent to all expected emails

R3 also receives “Outcome email, but NOT “Request for approval email”