-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: approvals for mrf #7636
Merged
Merged
feat: approvals for mrf #7636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature Todo:
|
kevin9foong
force-pushed
the
feat/mrf-approvals
branch
from
September 3, 2024 08:26
2d04e49
to
230e7f2
Compare
kevin9foong
had a problem deploying
to
staging-alt
September 3, 2024 08:51 — with
GitHub Actions
Failure
kevin9foong
had a problem deploying
to
staging-alt
September 5, 2024 02:21 — with
GitHub Actions
Failure
kevin9foong
temporarily deployed
to
staging-alt
September 5, 2024 02:29 — with
GitHub Actions
Inactive
kevin9foong
force-pushed
the
feat/mrf-approvals
branch
2 times, most recently
from
September 5, 2024 03:50
0e199c4
to
e41f928
Compare
Moving to testing phase:
|
Add |
kevin9foong
force-pushed
the
feat/mrf-approvals
branch
from
September 12, 2024 03:02
4c26b03
to
72d3722
Compare
|
kevin9foong
force-pushed
the
feat/mrf-approvals
branch
10 times, most recently
from
September 16, 2024 05:20
6dc8154
to
6d4d883
Compare
KenLSM
reviewed
Sep 16, 2024
KenLSM
reviewed
Sep 16, 2024
...create/builder-and-design/BuilderAndDesignDrawer/FieldListDrawer/FieldListDrawer.stories.tsx
Show resolved
Hide resolved
kevin9foong
force-pushed
the
feat/mrf-approvals
branch
from
September 25, 2024 07:47
3d57bf9
to
eb13119
Compare
KenLSM
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
From mrf workshops and user testing sessions, admins want a way for mrf to be used for their approval processes.
Closes FRM-1632, FRM-1829, FRM-1834, FRM-1835, FRM-1836, FRM-1856, FRM-1863
Solution
Implement approval support for mrf according to Approvals v8.
Breaking Changes
Features:
Improvements:
Before & After Screenshots
Revamped workflow builder (inactive state):
Revamped workflow builder (Active state):
New approvals outcome email:
Manual QA Tests
Test set up:
Use for approvals
badge appears beside yes/no fields in drawer.TC1: Regression test - MRF still works
TC2: Regression test - email notif works:
TC3: Approve without email notif. Expect no email sent
TC4: Reject without email notif. Expect no email sent
TC5: Approve and reject with email notification works:
TC6: Multiple approval steps - approve all
TC7: Multiple approval steps - Reject at step 2 (middle step)
TC8: Multiple approval steps - Reject at last step
Edge cases:
TC10: approval field set to optional, respondent did not fill
TC10: approval field deleted, admin did not reassign