fix: add default values for sendMrfOutcomeEmails isApproval and isRej…

…ected
opengovsg · Sep 5, 2024 · 0e199c4 · 0e199c4
1 parent a0c7af2
commit 0e199c4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/...pp/modules/submission/multirespondent-submission/multirespondent-submission.controller.ts b/...pp/modules/submission/multirespondent-submission/multirespondent-submission.controller.ts
@@ -567,7 +567,6 @@ const updateMultirespondentSubmission = async (
         responses,
         submissionId,
         isApproval: checkIsFormApproval(form),
-        isRejected: false,
       })
     } catch (err) {
       logger.error({

diff --git a/src/app/modules/submission/multirespondent-submission/multirespondent-submission.service.ts b/src/app/modules/submission/multirespondent-submission/multirespondent-submission.service.ts
@@ -121,15 +121,15 @@ export const sendMrfOutcomeEmails = ({
   form,
   responses,
   submissionId,
-  isApproval,
-  isRejected,
+  isApproval = false,
+  isRejected = false,
 }: {
   currentStepNumber: number
   form: IPopulatedMultirespondentForm
   responses: FieldResponsesV3
   submissionId: string
-  isApproval: boolean
-  isRejected: boolean
+  isApproval?: boolean
+  isRejected?: boolean
 }): ResultAsync<true, InvalidWorkflowTypeError | MailSendError> => {
   const logMeta = {
     action: 'sendMrfOutcomeEmails',