Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove p-queue from be #7693

Merged
merged 2 commits into from
Sep 25, 2024
Merged

chore: remove p-queue from be #7693

merged 2 commits into from
Sep 25, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Sep 18, 2024

Problem

p-queue is not used on the BE. Likely a legacy package since we didn't have an FE / BE split on package.json. This results in the root/package.json to require p-queue

Solution

Breaking Changes

  • No - this PR is backwards compatible

…d-deps-2

# Conflicts:
#	package-lock.json
#	package.json
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Sep 25, 2024

Datadog Report

Branch report: chore/remove-unused-deps-2
Commit report: 1fb4bc9
Test service: formsg

✅ 0 Failed, 2894 Passed, 1 Skipped, 1m 49.1s Total duration (4m 11.43s time saved)
➡️ Test Sessions change in coverage: 1 no change

@KenLSM KenLSM merged commit 9168b43 into develop Sep 25, 2024
15 checks passed
@KenLSM KenLSM deleted the chore/remove-unused-deps-2 branch September 25, 2024 13:17
@kevin9foong kevin9foong mentioned this pull request Sep 26, 2024
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants