Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: release v6.111.0 #7117

Merged
merged 9 commits into from
Mar 4, 2024
Merged

build: release v6.111.0 #7117

merged 9 commits into from
Mar 4, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Mar 4, 2024 •
edited
Loading

New

  • feat(fe): update copy, copy btn #7116
  • feat(virus-scanner): allow endpoint to be specified #7114
  • chore: remove Anguilla from country listing #7108
  • chore(vscode): update code actions value options #7113
  • feat(mrf): disable unsupported features #7106
  • fix: correct alignment issues in preview mode #7109
  • chore(OSS): add FerretDB migration instructions #7107
  • build: merge v6.110.0 back into develop #7105
  • build: release v6.110.0 #7104

Dependencies

Dev-Dependencies

Tests

feat(virus-scanner): allow endpoint to be specified #7114

@KenLSM

Regression on non-local development env

Virus scanner rejects test virus file

  • Create a form with attachments
  • Submit a test virus file
  • Observe that submission fails

Virus scanner passes virus-safe file

  • Create a form with attachments
  • Submit a plain text file
  • Observe that submission passes

feat(mrf): disable unsupported features #7106

@kathleenkhy

New feature tests

Admin MRF Forms - Unsupported fields are disabled

  • As an Admin create a MRF form (kathleen - edit: corrected to MRF form cause the steps worked for me for that)
  • Ensure that Attachment Field is disabled
    • Ensure that Attachment Field cannot be added as a form field
  • Ensure that on Mobile Field, the OTP toggle is disabled
  • Ensure that on Email Field, the OTP toggle is disabled
  • Ensure that on Email Field, the OTP and email confirmation toggles are disabled

Respondent MRF Forms - Feedback section is not shown

  • As a respondent, submit an MRF form
  • Ensure that form feedback section is not shown
Regression

Non-MRF Forms - fields that are disabled on MRF should not affect non-MRF forms

  • As an Admin create a non-MRF form
  • Ensure that Attachment Field is not disabled
  • Ensure that Attachment Field can be added as a form field
  • Ensure that on Mobile Field, the OTP toggle is not disabled
  • Ensure that on Email Field, the OTP and email confirmation toggles are not disabled

Respondent Non-MRF Forms - Feedback section is shown

  • As a respondent, submit a form
  • Ensure that form feedback section is shown

fix: correct alignment issues in preview mode #7109

@KenLSM

  • Add a payment variable to a form
  • Edit the Thank You page such that the title and follow-up instructions are very long
  • Click on the Preview (eye) button of the form in admin mode to enter Preview mode
  • The title and follow up instructions text (which are very long) should still be within the Summary table
  • In mobile view, the preview banner instructions and components should have sufficient padding

justynoh and others added 9 commits February 21, 2024 14:41
@justynoh
Merge pull request #7105 from opengovsg/release-al2
48376b6 
build: merge v6.110.0 back into develop
@KenLSM
chore(OSS): add FerretDB migration instructions (#7107)
87dc252 
chore: add ferretdb migration instructions
@kathleenkhy
fix: correct alignment issues in preview mode (#7109)
7e1b9c8 
* fix: correct alignment issues in preview mode

* fix: add different padding for edit vs preview mode
@KenLSM
feat(mrf): disable unsupported features (#7106)
ac0c695 
* feat: remove attachment field on mrf builder

* feat: disable vfn on mobile no

* feat: disable vfn on email

* feat: hide feedback section on mrf

* chore: remove redundant comments, rename boolean to be more grammatically consistent

* feat: disable email cnfrmtn on email field

* fix: add missing storybook params

* chore: rename props
@KenLSM
chore(vscode): update code actions value options (#7113)
c2db633 
chore: update code actions value options
@KenLSM
chore: remove Anguilla from country listing (#7108)
da55f39
@LoneRifle
feat(virus-scanner): allow endpoint to be specified (#7114)
e0d6ac4 
For environments that are neither AWS nor local dev, the virus scanner
lambda might be hosted elsewhere, eg, on a host running an emulated
environment. Grant the flexibility to specify the endpoint address to
reach the virus scanner, and thus the discretion to use AWS or some
other environment.
@KenLSM
feat(fe): update copy, copy btn (#7116)
3747f92 
* feat: update copy, copy btn

* chore: remove unintended box-flex switch
@KenLSM
chore: bump version to v6.111.0
d71e1bf
@KenLSM KenLSM requested review from justynoh and kathleenkhy March 4, 2024 05:00
@KenLSM KenLSM merged commit d37282c into release-al2 Mar 4, 2024
80 of 82 checks passed
@KenLSM KenLSM deleted the release_v6.111.0 branch March 4, 2024 07:43
This was referenced Mar 6, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathleenkhy kathleenkhy kathleenkhy approved these changes

@justynoh justynoh Awaiting requested review from justynoh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KenLSM @kathleenkhy @justynoh @LoneRifle