Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fe): update copy, copy btn #7116

Merged
merged 2 commits into from
Mar 4, 2024
Merged

feat(fe): update copy, copy btn #7116

merged 2 commits into from
Mar 4, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Mar 1, 2024 •
edited
Loading

Problem

There's a better test card filling UX in Airwallex, and found that we are lacking behind.

Screenshot 2024-03-01 at 2 32 15 PM

Solution

  • Update card filling copy
  • Add copy button that copies test card number over to user's clipboard

Breaking Changes

  • No - this PR is backwards compatible

Before & After Screenshots

Screenshot 2024-03-01 at 7 02 53 PM Screenshot 2024-03-01 at 7 02 48 PM Screenshot 2024-03-01 at 7 02 43 PM

@KenLSM KenLSM requested review from justynoh and kathleenkhy March 1, 2024 11:07
kathleenkhy
kathleenkhy approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@kathleenkhy kathleenkhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@KenLSM KenLSM merged commit 3747f92 into develop Mar 4, 2024
30 checks passed
@KenLSM KenLSM deleted the feat/copy-test-card branch March 4, 2024 02:42
@KenLSM KenLSM mentioned this pull request Mar 4, 2024
Merged
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathleenkhy kathleenkhy kathleenkhy approved these changes

@justynoh justynoh Awaiting requested review from justynoh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KenLSM @kathleenkhy