-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct alignment issues in preview mode #7109
Conversation
@kathleenkhy could we have some commentary, added on the Problem Section of the PR message, on how this occurred (a mini-root cause analysis). Was it a regression introduced by the previous PR? i.e.:
|
@kathleenkhy Sorry for being so anal on your PRs -- we don't usually do a full RCA on the PR itself, but since these are your first few PRs, we want to be a little more hands-on to make sure that we're taking away lessons whenever possible. |
934044e
to
95fd061
Compare
@KenLSM no worries and thanks for the feedback 🙂! I added the finding I had in the problem section (I didn't define the width as 100% which caused the text to bleed)! Lmk if I should add more details! |
95fd061
to
339c64d
Compare
339c64d
to
136c334
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (did pair programming to reduce the changes required)
Problem
There were alignment issues found where the text would bleed out of the page and container if the text is too long.
Root cause: Originally, the width of the Stack component in
PaymentEndPagePreview.tsx
was not indicated to be 100%, which might have caused the text to bleed since no width was defined. In the Edit mode and the actual Thank You Page (which worked as intended and the text did not bleed), the widths were defined as 100%.Closes FRM-1656
Solution
Breaking Changes
Before & After Screenshots
BEFORE:
Mobile View
AFTER:
Desktop View
Mobile View
Tests