Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release v5.64.0 #4139

Merged
merged 24 commits into from
Jul 12, 2022
Merged

build: release v5.64.0 #4139

merged 24 commits into from
Jul 12, 2022

Conversation

justynoh
Copy link
Contributor

New dependencies

  • chore(deps-dev): bump ts-node-dev from 1.1.8 to 2.0.0 #4123
  • chore(deps-dev): bump @types/validator from 13.7.3 to 13.7.4 #4126
  • chore(deps-dev): bump lint-staged from 13.0.1 to 13.0.3 #4127
  • chore(deps-dev): bump csv-parse from 5.0.4 to 5.2.2 #4122
  • chore(deps-dev): bump ts-essentials from 9.1.2 to 9.2.0 #4124
  • fix(deps): bump nodemailer from 6.7.5 to 6.7.7 #4113
  • fix(deps): bump @sentry/browser from 7.4.1 to 7.5.1 #4115
  • fix(deps): bump moment from 2.29.2 to 2.29.4 #4116
  • chore(deps-dev): bump maildev from 2.0.4 to 2.0.5 #4114
  • chore(deps-dev): bump concurrently from 7.1.0 to 7.2.2 #4100
  • chore(deps-dev): bump @types/node from 18.0.0 to 18.0.1 #4099
  • fix(deps): bump aws-sdk from 2.1136.0 to 2.1167.0 #4101
  • chore(deps-dev): bump @babel/preset-env from 7.17.12 to 7.18.6 #4086
  • fix(deps): bump openid-client from 5.1.7 to 5.1.8 #4088
  • fix(deps): bump type-fest from 2.15.1 to 2.16.0 in /shared #4091
  • fix(deps): bump twilio from 3.77.0 to 3.78.0 #4078
  • chore(deps-dev): bump @babel/core from 7.18.5 to 7.18.6 #4079
  • fix(deps): bump @sentry/browser from 7.2.0 to 7.4.1 #4080

Features

  • fix: bounce notification #4107
  • fix: update sgid client to v1.0.3 (again) #4090
  • feat: add backend validation for form feedback submission #3941
  • update: number of bcrypt salt rounds for otp and myinfo hashing #4075

dependabot bot and others added 24 commits July 4, 2022 10:58
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 7.2.0 to 7.4.1.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@7.2.0...7.4.1)

---
updated-dependencies:
- dependency-name: "@sentry/browser"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.18.5 to 7.18.6.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.18.6/packages/babel-core)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [twilio](https://github.com/twilio/twilio-node) from 3.77.0 to 3.78.0.
- [Release notes](https://github.com/twilio/twilio-node/releases)
- [Changelog](https://github.com/twilio/twilio-node/blob/main/CHANGES.md)
- [Commits](twilio/twilio-node@3.77.0...3.78.0)

---
updated-dependencies:
- dependency-name: twilio
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: add new feedback api route

* feat: link Angular FE to new feedback endpoint

* refactor: feedback controller

* refactor: feedback controller log meta

* feat: add tests for services

* feat: add test for new feedback endpoint

* fix: update failing FE tests

* fix: update error status code duplicate feedback

* refactor: rename formSubmissionId to submissionId

* refactor: feedback controller submitFormFeedbackV2

* fix: update according to PR comments

* refactor: move submission.feedback.routes tests to feedback.routes

* chore: update TODO comments to link issue number

* refactor: rename feedback.error file and some constants

* chore: add TODO comments linking to issue #3964

* fix: update feedback related error messages

* refactor: update feedback model index syntax

* chore: add TODO comments for feedback tests

* fix: remove unecessary formId field in hasNoPreviousFeedback

* fix: update FormFeedbackBase submissionId field to optional

* refactor: form feedback tests to merge into one describe route

* refactor: move submissions.feedback route to feedback route

* fix: update log message for form feedback submission
Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 2.15.1 to 2.16.0.
- [Release notes](https://github.com/sindresorhus/type-fest/releases)
- [Commits](sindresorhus/type-fest@v2.15.1...v2.16.0)

---
updated-dependencies:
- dependency-name: type-fest
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [openid-client](https://github.com/panva/node-openid-client) from 5.1.7 to 5.1.8.
- [Release notes](https://github.com/panva/node-openid-client/releases)
- [Changelog](https://github.com/panva/node-openid-client/blob/main/CHANGELOG.md)
- [Commits](panva/openid-client@v5.1.7...v5.1.8)

---
updated-dependencies:
- dependency-name: openid-client
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.17.12 to 7.18.6.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.18.6/packages/babel-preset-env)

---
updated-dependencies:
- dependency-name: "@babel/preset-env"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: cherry pick from pr #3905

* fix: specify sgid scopes and null nonce

* fix: fix package-lock.json merge conflict

* fix: update sgid tests

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kar Rui <[email protected]>
build: merge release 5.63.2 into develop
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1136.0 to 2.1167.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.1136.0...v2.1167.0)

---
updated-dependencies:
- dependency-name: aws-sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 18.0.0 to 18.0.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [concurrently](https://github.com/open-cli-tools/concurrently) from 7.1.0 to 7.2.2.
- [Release notes](https://github.com/open-cli-tools/concurrently/releases)
- [Commits](open-cli-tools/concurrently@v7.1.0...v7.2.2)

---
updated-dependencies:
- dependency-name: concurrently
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [maildev](https://github.com/maildev/maildev) from 2.0.4 to 2.0.5.
- [Release notes](https://github.com/maildev/maildev/releases)
- [Commits](maildev/maildev@v2.0.4...v2.0.5)

---
updated-dependencies:
- dependency-name: maildev
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [moment](https://github.com/moment/moment) from 2.29.2 to 2.29.4.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](moment/moment@2.29.2...2.29.4)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 7.4.1 to 7.5.1.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@7.4.1...7.5.1)

---
updated-dependencies:
- dependency-name: "@sentry/browser"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [nodemailer](https://github.com/nodemailer/nodemailer) from 6.7.5 to 6.7.7.
- [Release notes](https://github.com/nodemailer/nodemailer/releases)
- [Changelog](https://github.com/nodemailer/nodemailer/blob/master/CHANGELOG.md)
- [Commits](nodemailer/nodemailer@v6.7.5...v6.7.7)

---
updated-dependencies:
- dependency-name: nodemailer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ts-essentials](https://github.com/krzkaczor/ts-essentials) from 9.1.2 to 9.2.0.
- [Release notes](https://github.com/krzkaczor/ts-essentials/releases)
- [Changelog](https://github.com/ts-essentials/ts-essentials/blob/master/CHANGELOG.md)
- [Commits](ts-essentials/ts-essentials@v9.1.2...v9.2.0)

---
updated-dependencies:
- dependency-name: ts-essentials
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [csv-parse](https://github.com/adaltas/node-csv/tree/HEAD/packages/csv-parse) from 5.0.4 to 5.2.2.
- [Release notes](https://github.com/adaltas/node-csv/releases)
- [Changelog](https://github.com/adaltas/node-csv/blob/master/packages/csv-parse/CHANGELOG.md)
- [Commits](https://github.com/adaltas/node-csv/commits/[email protected]/packages/csv-parse)

---
updated-dependencies:
- dependency-name: csv-parse
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: update controller with hasNotified check

* test: update controller tests

* ref: reinstate bounce types

* test: remove redundant test

Co-authored-by: wanlingt <[email protected]>
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 13.0.1 to 13.0.3.
- [Release notes](https://github.com/okonet/lint-staged/releases)
- [Commits](lint-staged/lint-staged@v13.0.1...v13.0.3)

---
updated-dependencies:
- dependency-name: lint-staged
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/validator](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/validator) from 13.7.3 to 13.7.4.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/validator)

---
updated-dependencies:
- dependency-name: "@types/validator"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ts-node-dev](https://github.com/whitecolor/ts-node-dev) from 1.1.8 to 2.0.0.
- [Release notes](https://github.com/whitecolor/ts-node-dev/releases)
- [Changelog](https://github.com/wclr/ts-node-dev/blob/master/CHANGELOG.md)
- [Commits](wclr/ts-node-dev@v1.1.8...v2.0.0)

---
updated-dependencies:
- dependency-name: ts-node-dev
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@justynoh
Copy link
Contributor Author

justynoh commented Jul 12, 2022

Tests

fix: bounce notification #4107

@justynoh

  • Create an email mode form. Add a valid collaborator with a registered contact number, and add a non-existent email as one of the email recipients. Submit the form. The form should NOT be deactivated, and the valid email recipient should not receive any emails/SMSes. Check the document in the Bounces collection corresponding to the form ID. The bounces array should contain the correct hasBounced key for each email address.
  • Remove all valid email recipients and leave only non-existent emails. Submit the form. The form should be deactivated, and the form admin + collaborators should each receive only ONE email and TWO smses, informing them of the bounce and form deactivation.

@justynoh
Copy link
Contributor Author

justynoh commented Jul 12, 2022

fix: update sgid client to v1.0.3 (again) #4090
@tshuli

  • test sgid flow on staging

@justynoh
Copy link
Contributor Author

justynoh commented Jul 12, 2022

feat: add backend validation for form feedback submission #3941

@karrui

  • Test that submitting a feedback with submissionId for a form without a prior form submission with the same submissionId returns 404
  • Test that submitting feedback twice for the same submissionId and formId returns 422
  • Test that feedback using only endpoint of /api/v3/forms/{formId}/feedback still works
  • Test that old client works with new server both locally and on staging (load the submit feedback page on the old client, deploy the new version of the code, then submit feedback to see that feedback submission still works)

@justynoh
Copy link
Contributor Author

justynoh commented Jul 12, 2022

update: number of bcrypt salt rounds for otp and myinfo hashing #4075

@justynoh

  • Test that we can request OTP and successfully verify the OTP on the new server
  • Test that we can request OTP on the old server, switch to the new server (with salt rounds reduced to 1), and verify the requested OTP on the new server

@justynoh justynoh merged commit 679607f into release-al2 Jul 12, 2022
@justynoh justynoh deleted the release-v5.64.0 branch July 12, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants