fix: bounce notification

[wanlingt]

Problem

Users are spammed with multiple smses and emails after email-mode responses bounce

Closes #4094

Solution

Re-introduce hasNotified, which checks if form admins and collaborators have already been sms-ed or emailed after an email response's critical bounce.

Breaking Changes

• No - this PR is backwards compatible

Tests

Same tests as those in Bounce module refactor PR

• Create an email mode form. Add a valid collaborator with a registered contact number, and add a non-existent email as one of the email recipients. Submit the form. The form should NOT be deactivated, and the valid email recipient should not receive any emails/SMSes. Check the document in the Bounces collection corresponding to the form ID. The bounces array should contain the correct hasBounced key for each email address.
• Remove all valid email recipients and leave only non-existent emails. Submit the form. The form should be deactivated, and the form admin + collaborators should each receive only ONE email and TWO smses, informing them of the bounce and form deactivation.

[timotheeg]

Just to make reveiwing the changeset easier, load it with ignore-whitespace enabled.

Since the PR introduces a branching behaviour, a new test needs to be added where hasNotified() is set to return true, and the test verifies that sendEmailBounceNotification() is not called.

[wanlingt]

Just to make reveiwing the changeset easier, load it with ignore-whitespace enabled.

Since the PR introduces a branching behaviour, a new test needs to be added where hasNotified() is set to return true, and the test verifies that sendEmailBounceNotification() is not called.

Thanks Tim! Didn't know about the whitespace setting, its really useful. I've added new tests for hasNotified() set to true

[timotheeg]

lgtm 👍

I think the unit tests could be refactored at some point to be a bit more granular, but we can revisit that another time. Let's get this out to help admins.