refactor: convert Bounce module to use neverthrow #1591
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Bounce module to use
neverthrow
.A note on PR scope: there is a lot of refactoring that can be done in the Bounce module, but I don't think it should be a priority right now. The module is complex and was based on a long process of designing and refining, and refactoring it will not only take a long time but risks disrupting a service which has been automated for nearly a year. Hence I think a deeper refactor is out of scope of this PR, unless any part of it is genuinely un-readable.
Closes #193
Manual tests
bounces
array should contain the correcthasBounced
key for each email addres.