Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form Feedback API Cleanup #3964

Closed
hanstirtaputra opened this issue Jun 7, 2022 · 0 comments · Fixed by #4085
Closed

Form Feedback API Cleanup #3964

hanstirtaputra opened this issue Jun 7, 2022 · 0 comments · Fixed by #4085
Assignees
@hanstirtaputra

Comments

@hanstirtaputra
Copy link
Contributor

Form feedback validation PR deprecates the old /api/v3/forms/{formId}/feedback route in favour of /api/v3/forms/{formId}/submissions/{submissionId}/feedback. Clean up the old /api/v3/forms/{formId}/feedback route once we fully migrate to the new feedback API.
@hanstirtaputra hanstirtaputra self-assigned this Jun 7, 2022
@hanstirtaputra hanstirtaputra mentioned this issue Jun 7, 2022
Merged
6 tasks
hanstirtaputra added a commit that referenced this issue Jun 13, 2022
@hanstirtaputra
chore: add TODO comments linking to issue #3964
533aabb
hanstirtaputra added a commit that referenced this issue Jun 28, 2022
@hanstirtaputra
chore: add TODO comments linking to issue #3964
8da761c
hanstirtaputra added a commit that referenced this issue Jul 4, 2022
@hanstirtaputra
chore: add TODO comments linking to issue #3964
9dc9969
hanstirtaputra added a commit that referenced this issue Jul 4, 2022
@hanstirtaputra
feat: add backend validation for form feedback submission (#3941)
7d094c2 
* feat: add new feedback api route

* feat: link Angular FE to new feedback endpoint

* refactor: feedback controller

* refactor: feedback controller log meta

* feat: add tests for services

* feat: add test for new feedback endpoint

* fix: update failing FE tests

* fix: update error status code duplicate feedback

* refactor: rename formSubmissionId to submissionId

* refactor: feedback controller submitFormFeedbackV2

* fix: update according to PR comments

* refactor: move submission.feedback.routes tests to feedback.routes

* chore: update TODO comments to link issue number

* refactor: rename feedback.error file and some constants

* chore: add TODO comments linking to issue #3964

* fix: update feedback related error messages

* refactor: update feedback model index syntax

* chore: add TODO comments for feedback tests

* fix: remove unecessary formId field in hasNoPreviousFeedback

* fix: update FormFeedbackBase submissionId field to optional

* refactor: form feedback tests to merge into one describe route

* refactor: move submissions.feedback route to feedback route

* fix: update log message for form feedback submission
@hanstirtaputra hanstirtaputra mentioned this issue Jul 4, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hanstirtaputra hanstirtaputra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: cleanup deprecated feedback API opengovsg/FormSG
1 participant
@hanstirtaputra