chore: cleanup deprecated feedback API #4085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanstirtaputra
force-pushed
the
chore/cleanup-feedback-api
branch
from
af33784 to
24a809f
Compare
hanstirtaputra
changed the title
|
still 25 requests to the old endpoint in the past week, think we can afford to wait another week |
|
still quite a few requests, suspect this will have a long tail, we can hold off first and check in again in a month |
mantariksh
approved these changes
Sep 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Adding the new form feedback API in #3941 causes the old
/api/v3/forms/{formId}/feedbackroute to be deprecated. We need to cleanup the deprecated API route and its related code.Closes #3964
Solution
Cleanup the deprecated
/api/v3/forms/{formId}/feedbackfeedback API route and related test cases.Breaking Changes
Tests