Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v2): [Date1] add DateRangePicker/Input component #3199

Merged
merged 22 commits into from
Jan 14, 2022
Merged

feat(v2): [Date1] add DateRangePicker/Input component #3199

merged 22 commits into from
Jan 14, 2022

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Dec 16, 2021

This PR builds upon #3185

Problem

This PR adds a DateRangePicker component with the appropriate multi-month calendar popover.

Related to #2006

Solution

Features:

  • render multiple months correctly in multi-cal display
  • add DateRangePicker component
  • add initial DateRangeInput component
  • style: add gradient styling when range is across months

Bug Fixes:

  • fix: prevent spacebar from opening native date picker

Before & After Screenshots

New DateRangeInput stories have been added

Tests

SORRY

@karrui karrui requested a review from mantariksh December 16, 2021 16:02
@karrui karrui mentioned this pull request Dec 16, 2021
Merged
@karrui karrui changed the title feat(v2): add DateRangePicker/Input component feat(v2): [Date1] add DateRangePicker/Input component Dec 16, 2021
@karrui karrui force-pushed the form-v2/date-range-picker-1 branch from afd626e to 81553d6 Compare January 13, 2022 06:52
Base automatically changed from form-v2/date-component to form-v2/develop January 13, 2022 09:19
karrui added 20 commits January 13, 2022 17:20
@karrui
feat: render multiple months correctly in multi-cal display
c63e50c
@karrui
fix: prevent calendar from switching when clicking on offset month
8bbffa2
@karrui
feat: add more props to context for styling date range
dd7e63e
@karrui
feat: add styling for picking date range
ef67e32
@karrui
feat: add DateRangePicker component
eae6194
@karrui
feat: add initial DateRangeInput component
070bb84
@karrui
feat: add initial stories for DateRangePicker and playground
3c92cee
@karrui
fix(DayOfMonth): use isSameDay over isEqual (account for timezones)
a4fd24d
@karrui
feat(story): add picker with prepopulated date story
b41a58d
@karrui
fix(CalendarContext): allow focus on selected dates in multi-cal view
05cda05
@karrui
style: add gradient styling when range is across months
c2763e2 
also move day button bg style interpolation out to component
@karrui
feat(story): update story with date story to span across month
e484dbc 
for maximum style check
@karrui
feat: add logic (and styling) for handling controlled date selection
d2b322b
@karrui
ref(Input): move some styles to baseStyle
6fc0fe5
@karrui
ref: clean up date range input styling
ce8f477
@karrui
feat(story): add mockdate to prevent flaky calendar snapshots
b860849
@karrui
fix: clean up unused imports
25b436b
@karrui
feat: format picked dates to string instead of Date
58ce5ff
@karrui
fix: prevent spacebar from opening native date picker
aa614b4
@karrui
Revert "ref(Input): move some styles to baseStyle"
0a906b9 
This reverts commit 0b1d44a44064e371a09c00011a8b2db4e91aa1e0.
@karrui karrui force-pushed the form-v2/date-range-picker-1 branch from 81553d6 to 0a906b9 Compare January 13, 2022 09:21
@karrui karrui merged commit a0c0d34 into form-v2/develop Jan 14, 2022
@karrui karrui deleted the form-v2/date-range-picker-1 branch January 14, 2022 04:58
This was referenced Oct 4, 2022
Closed
Merged
@justynoh justynoh mentioned this pull request Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantariksh mantariksh Awaiting requested review from mantariksh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@karrui