-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): [Date0] add single date DatePicker component #3185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrui
force-pushed
the
form-v2/date-component
branch
2 times, most recently
from
December 16, 2021 08:44
b064963
to
c0df992
Compare
karrui
changed the title
feat(v2): add single date DatePicker component
feat(v2): [Date0] add single date DatePicker component
Dec 16, 2021
8 tasks
allows navigation with keyboard, but still disallows selection
also change base type from box to chakra.button
on iOS, changing the months/years actually triggers a blur event for some reason. This commit prevents the popover from closing when that happens.
karrui
force-pushed
the
form-v2/date-component
branch
from
January 13, 2022 06:52
8c89af6
to
3dea013
Compare
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR adds the SINGLE DATE date picker component. The range version will come in a later PR
Closes #2006
Solution
Features:
DatePicker
componentBefore & After Screenshots
New DatePicker story is included
Tests
Will add unit tests soooooooooon
Deploy Notes
New dependencies:
dayzed
: headless datepicker libraryreact-use
: hooks, used here for key navigationuuid
: generate unique class names for focus navigation with arrow keys