feat(v2): [Date2] add a11y improvements to DatePicker components #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrui
changed the title
karrui
force-pushed
the
form-v2/date-a11y-2
branch
from
ae53e7f to
16011b4
Compare
karrui
force-pushed
the
form-v2/date-a11y-2
branch
3 times, most recently
from
aac7f11 to
21bba63
Compare
Base automatically changed from
form-v2/date-range-picker-1
to
form-v2/develop
January 14, 2022 04:58
karrui
force-pushed
the
form-v2/date-a11y-2
branch
from
34eaa3e to
6276f16
Compare
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR adds the missing a11y alerts/tab indices to the DatePicker components
Closes #2006
Solution
Features:
Improvements:
Bug Fixes:
Before & After Screenshots
Stories should be automatically updated
Deploy Notes
New dependencies:
react-focus-lock: lock focus inside calendar