-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate admin-console client service to ts #1531
refactor: migrate admin-console client service to ts #1531
Conversation
…Form and getExampleForms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the JSDoc for getExampleForms is incomplete because i'm unsure how to describe them. the corresponding backend controller examples.controller doesn't have the documentation defined on the parameter/type. will ask around and write it up
Thanks, noted. Appreciate it if you could derive and fill in the backend JSDocs, if they're missing too?
Meanwhile, you should actually switch over to using the TS implementation and delete the old JS files. Don't forget to test on staging if you have to.
@liangyuanruo yep, i'm going to check with either @karrui or @mantariksh and fill in both fe/be documentation |
1b87df9
to
85a7641
Compare
85a7641
to
300f708
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some queries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, please add manual test steps for next release
This PR may have conflicts with #1573, please coordinate :P |
talked to @orbitalsqwib on this. we finalized that i'll merge my PR in first and he'll rebase/merge off this accordingly. @karrui fyi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, do address/resolve Antariksh's comments before merging.
Problem
Closes #1521 - refactors
admin-console.client.service.js
into two separate frontend services and writes adds tests for themSolution
Rewrote the
admin-console
service as two separate services in typescript.Followed backend structure and structured it as
exampleService
andbillingService
Tests
1.tests for
billingService
/exampleService
to ensure that api requests are being carried out and to ensure that errors are being thrown if promises are rejectedManual tests
examples
after logging in - there should be multiple examples loaded