test(billingservice): updated tests to use dto for params

opengovsg · Apr 1, 2021 · 300f708 · 300f708
1 parent 1f08ca9
commit 300f708
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 13 deletions.
diff --git a/src/app/modules/billing/__tests__/billing.controller.spec.ts b/src/app/modules/billing/__tests__/billing.controller.spec.ts
@@ -92,7 +92,9 @@ describe('billing.controller', () => {
         ...EXPECTED_SERVICE_CALL_ARGS,
       )
       expect(mockRes.status).toBeCalledWith(500)
-      expect(mockRes.json).toBeCalledWith('Error in retrieving billing records')
+      expect(mockRes.json).toBeCalledWith({
+        message: 'Error in retrieving billing records',
+      })
     })
   })
 })
diff --git a/src/app/modules/billing/__tests__/billing.routes.spec.ts b/src/app/modules/billing/__tests__/billing.routes.spec.ts
@@ -206,7 +206,9 @@ describe('billing.routes', () => {
       // Assert
       expect(retrieveStatsSpy).toBeCalled()
       expect(response.status).toEqual(500)
-      expect(response.body).toEqual('Error in retrieving billing records')
+      expect(response.body).toEqual({
+        message: 'Error in retrieving billing records',
+      })
     })
   })
 })

diff --git a/src/public/services/__tests__/BillingService.test.ts b/src/public/services/__tests__/BillingService.test.ts
@@ -19,11 +19,7 @@ describe('BillingService', () => {
       MockAxios.get.mockResolvedValueOnce({ data: MOCK_DATA })
 
       // Act
-      const actual = await BillingService.getBillingInfo(
-        MOCK_PARAMS.yr,
-        MOCK_PARAMS.mth,
-        MOCK_PARAMS.esrvcId,
-      )
+      const actual = await BillingService.getBillingInfo(MOCK_PARAMS)
 
       // Assert
       expect(MockAxios.get).toHaveBeenCalledWith(
@@ -38,12 +34,7 @@ describe('BillingService', () => {
     it('should reject with the provided error message when the GET request fails', async () => {
       // Arrange
       const expected = new Error('Mock Error')
-      const shouldReject = () =>
-        BillingService.getBillingInfo(
-          MOCK_PARAMS.yr,
-          MOCK_PARAMS.mth,
-          MOCK_PARAMS.esrvcId,
-        )
+      const shouldReject = () => BillingService.getBillingInfo(MOCK_PARAMS)
       MockAxios.get.mockRejectedValueOnce(expected)
 
       // Act