Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert admin-console.client.service.js to TypeScript #1521

Closed
liangyuanruo opened this issue Mar 30, 2021 · 0 comments · Fixed by #1531
Closed

Convert admin-console.client.service.js to TypeScript #1521

liangyuanruo opened this issue Mar 30, 2021 · 0 comments · Fixed by #1531
Assignees
@seaerchin
Labels
easy possible issues that beginners can pick up to get acquainted with the codebase P2 planned for next 1-2 months

Comments

@liangyuanruo
Copy link
Contributor

In addition to conversion to TS, suggest splitting the existing service in two (just like the backend modules), into an Examples client service and Billing client service.
@liangyuanruo liangyuanruo added P2 planned for next 1-2 months easy possible issues that beginners can pick up to get acquainted with the codebase labels Mar 30, 2021
@liangyuanruo liangyuanruo mentioned this issue Mar 30, 2021
Closed
@seaerchin seaerchin mentioned this issue Mar 31, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seaerchin seaerchin

Labels
easy possible issues that beginners can pick up to get acquainted with the codebase P2 planned for next 1-2 months
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: migrate admin-console client service to ts opengovsg/FormSG
2 participants
@liangyuanruo @seaerchin