Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Release 4.30.4 #153

Merged
merged 33 commits into from
Aug 18, 2020
Merged

[master] Release 4.30.4 #153

merged 33 commits into from
Aug 18, 2020

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Aug 18, 2020

No description provided.

mantariksh and others added 30 commits August 5, 2020 09:22
* feat: add _id to all relevant types

* fix: omit id when declaring new document

* refactor: change any to Document['_id']
* feat: remove allowSms

* feat: add script to remove allowSms flag
* refactor: use LogicType instead of LOGIC_TYPES

* refactor: type logic module

* refactor: prefix interface names with I

* refactor: add interface containing fieldValue

* test: add logic type to tests

* refactor: add isPreventSubmitLogic function

* docs: document IClientFieldSchema

* refactor: make everything an arrow function
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.15...4.17.19)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [uuid](https://github.com/uuidjs/uuid) from 8.2.0 to 8.3.0.
- [Release notes](https://github.com/uuidjs/uuid/releases)
- [Changelog](https://github.com/uuidjs/uuid/blob/master/CHANGELOG.md)
- [Commits](uuidjs/uuid@v8.2.0...v8.3.0)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#101)

* fix: phone validation now only accepts 8 digit #s starting with 8 or 9

* fix: perform mobile validation checks only in mobile validation fn
Bumps [url-loader](https://github.com/webpack-contrib/url-loader) from 1.1.2 to 4.1.0.
- [Release notes](https://github.com/webpack-contrib/url-loader/releases)
- [Changelog](https://github.com/webpack-contrib/url-loader/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/url-loader@v1.1.2...v4.1.0)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* contributing guidelines

* full open source license

* contact email address
Bumps [angular](https://github.com/angular/angular.js) from 1.7.9 to 1.8.0.
- [Release notes](https://github.com/angular/angular.js/releases)
- [Changelog](https://github.com/angular/angular.js/blob/master/CHANGELOG.md)
- [Commits](angular/angular.js@v1.7.9...v1.8.0)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [angular-cookies](https://github.com/angular/angular.js) from 1.7.9 to 1.8.0.
- [Release notes](https://github.com/angular/angular.js/releases)
- [Changelog](https://github.com/angular/angular.js/blob/master/CHANGELOG.md)
- [Commits](angular/angular.js@v1.7.9...v1.8.0)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 3.3.11 to 3.3.12.
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/v3.3.12/CHANGELOG.md)
- [Commits](webpack/webpack-cli@v3.3.11...v3.3.12)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: correct discriminated field schema typings' inheritance

* chore: add typings for uid-generator

* feat: add validation error if table field does not have any columns

* feat(FieldSchema): add instance method getQuestion

* test(FormModel): add getQuestion field instance method tests

* refactor: retrieve field question using instance method

* feat: delete question.js

* feat(BaseField): add comment to getQuestion instance method

* test: migrate form field tests to form_fields.schema.spec

* test: use ObjectIds for field ids instead of string

was causing schema building to fail due to expecting a document instead of an object

* test: use objectId instead of string when building mongoose schemas
* chore: add ts-jest and dependencies

* chore: expand tsconfig to `test` directory

* chore: add jest config and script to run Typescript tests

* chore: improve import sort linting autogrouping

* tests: convert submission.server.model tests to Typescript

* chore: add jest-mongodb present to jest setup

This allows for use of mongodb without any setting up or tearing down of mongodb between tests

* test: migrate myinfo service test to Typescript

* feat: remove usage of spec in db-handler

* build: add specific tsconfig for building that ignores tests

* chore: add jest-mongodb-config and migrate SmsCountModel tests

With this, we can eventually stop using `npm run download-binary` and delete `tests/end-to-end/helpers/get-mongo-binary.js` since the config automatically retrieves that information for us.

* chore: add documentation to gitignore

* fix: check mongoose MD5 binary when starting jest tests

* refactor: convert form_fields schema tests to Typescript
* refactor: extract showAttachmentError

* refactor: replace object with boolean

* feat: only set success values upon success

* feat: show error on FileReader failure

* feat: only remove spinner upon success or failure

* refactor: use ng-class instead of jquery

* docs: document onerror

* chore: update error wording

Co-authored-by: Yuan Ruo <[email protected]>

* refactor: move fieldValue assignment together with file

* chore: remove double full stop

Co-authored-by: Antariksh Mahajan <[email protected]>
Co-authored-by: Yuan Ruo <[email protected]>
@tshuli tshuli merged commit d6550f5 into master Aug 18, 2020
@liangyuanruo liangyuanruo deleted the release-4.30.4 branch January 6, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants