Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove allowSms beta flag #73

Merged
merged 2 commits into from
Aug 5, 2020
Merged

feat: remove allowSms beta flag #73

merged 2 commits into from
Aug 5, 2020

Conversation

mantariksh
Copy link
Contributor

@mantariksh mantariksh commented Aug 4, 2020 •
edited
Loading

This PR removes the beta flag which blocks users from accessing the mobile number verification feature.

Tests

  • Email mode: check that you don't have the allowSms beta flag, and you can see the "Verified" option for mobile fields. Submit a form with a verified mobile number and check that the email response has the [verified] prefix.
  • Storage mode: check that you don't have the allowSms beta flag, and you can see the "Verified" option for mobile fields. Submit a form with a verified mobile number and check that the response in the Data tab has the [verified] prefix. Download the responses CSV and make sure the answer appears correctly (there won't be a [verified] prefix in the column header).

karrui
karrui approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mantariksh mantariksh merged commit a8ea798 into develop Aug 5, 2020
@mantariksh mantariksh deleted the allow-sms branch August 5, 2020 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrui karrui karrui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mantariksh @karrui