-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: setup jest for use with Typescript tests #106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drafting this, I want to explore using Jest's automatic mongodb setup. |
ea72089
to
8b42524
Compare
Ready for review. I think tests can be written in Typescript moving forward :) |
liangyuanruo
reviewed
Aug 9, 2020
liangyuanruo
approved these changes
Aug 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
largely lgtm! can i confirm the way to have jest run the tests instead of jasmine, is to convert them to TypeScript?
Yes. But also need to change all Jasmine usages to jest, and update the imports also
|
1d62e66
to
f7e544a
Compare
This allows for use of mongodb without any setting up or tearing down of mongodb between tests
With this, we can eventually stop using `npm run download-binary` and delete `tests/end-to-end/helpers/get-mongo-binary.js` since the config automatically retrieves that information for us.
f7e544a
to
d41fd00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to run Typescript tests with Jest. All tests with file names that match
will be run with Jest.
This PR also migrates a few tests to Typescript to check if
ts-jest
is working.Features:
tsconfig.json
to now allow for absolute imports:../../../../../<root>/some/path
->src/some/path
jest-mongodb-config
. With this, we can eventually stop usingnpm run download-binary
and deletetests/end-to-end/helpers/get-mongo-binary.js
since the config automatically retrieves that information for us.New scripts:
test-backend-jest
script to run jest teststest-backend
script now runs both jasmine and jest tests. Jasmine tests will be run first, followed by jest tests. Eventually, all tests will be written in Jest and Jasmine tests can be deleted.