fix: apply dropdown padding on whole table #1078
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In table fields, whenever dropdown fields are opened in the last 2 rows, we add padding to the bottom of the field so the dropdown options do not get hidden. This is broken in mobile view, likely since #894, resulting in dropdown options being hidden for the last row.
Solution
The problem is that table rows in mobile are
display: block;
as opposed todisplay: flex;
like in desktop, resulting in the padding being applied incorrectly. The fix was to apply the padding on the table field as a whole instead of just the last row, which has the same effect but works properly in mobile.Screenshots
Before (mobile)
After (mobile)
Before and after (desktop)
Tests