Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply dropdown padding on whole table #1078

Merged
merged 1 commit into from
Feb 4, 2021
Merged

fix: apply dropdown padding on whole table #1078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/public/modules/forms/base/componentViews/field-table.client.view.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@

<!-- Input -->
<div>
<!-- View for screen width >= 768px. Either this or the next div is shown. -->
<div class="table-scrollable table-desktop">
<!-- Labels to be shown in desktop mode but not mobile mode -->
<div
class="table-scrollable table-desktop"
ng-class="{ 'dropdownPadding': vm.hasEndPadding }"
>
<div class="table-row table-labels-desktop">
<!-- ng-class in ng-repeat below sets whether the column is col-xs-6, col-xs-12 or max-width -->
<div
Expand All @@ -38,10 +39,7 @@
ng-repeat="n in vm.generateTableRowIndexes()"
ng-init="$evenRow = $even; $oddRow = $odd"
>
<div
class="table-row"
ng-class="{ 'dropdownPadding': vm.hasEndPadding && vm.isLastRow(n) }"
>
<div class="table-row">
<!-- ng-class in ng-repeat below sets a couple of things:
=> whether a row is blue or white
=> whether the column is col-xs-6, col-xs-12 or max-width
Expand Down