Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release v4.50.2 hotfix #894

Merged
merged 2 commits into from
Dec 16, 2020
Merged

build: release v4.50.2 hotfix #894

merged 2 commits into from
Dec 16, 2020

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Dec 16, 2020

v4.50.2

This hotfix fixes the issue where dropdowns nested inside table fields being limited to only 30 entries. This bug was caused by having two HTML divs housing the same table field with the same dropdown id, resulting in the infinite scroll library only hooking to the desktop variant even on mobile view, resulting in the load more items call to the infinite scroll library not being triggered in mobile.

This is fixed by combining the two containers into a single container and styling it appropriately in both desktop and mobile view.

Fixes

  • update table field styling to not rely on multiple divs to fix nested dropdown fields in tables to not be limited to 30 elements

Screenshots

Before

Misaligned columns
Screenshot 2020-12-16 at 5 38 17 PM

Max scroll is 30
Screenshot 2020-12-16 at 5 39 09 PM

After

Aligned table columns
Screenshot 2020-12-16 at 5 40 52 PM

Can infinitely scroll now
Screenshot 2020-12-16 at 5 40 06 PM

@karrui karrui changed the base branch from develop to release December 16, 2020 08:11
@karrui
Copy link
Contributor Author

karrui commented Dec 16, 2020

Tests

Admin preview for table fields

  • Column can be added in admin preview
  • When deleting column in admin preview, correct column is deleted and the properties/filled in values of other columns are unaffected
  • Changing the number of minimum rows causes the preview to be rerendered with the minimum number of rows.
  • Column type can be changed from textfield to dropdown and vice versa without affecting properties of other columns
  • Clicking the delete row button deletes the correct row and maintains the values in all the other rows.
  • The alternating blue/white background for rows is maintained when deleting a row, even if is not the last row.
  • In preview, opening a dropdown in the last two rows adds padding between the last row and the bottom of the field
  • In preview, opening a dropdown field NOT in the last two rows does not add padding between the last row and the bottom of the field
  • When "Able to add more rows" is enabled, the text for number of rows (e.g. ("2 out of 4 rows") updates correctly when rows are added and deleted
  • When "Able to add more rows" is enabled, the text for maximum number of rows (e.g. ("2 out of 4 rows") updates correctly when "Maximum rows allowed" is updated
  • When options for dropdown fields are updated, the options in the preview are updated as well
  • The table is rendered correctly when there is a mix of optional and required columns.

Table fields in forms (desktop view)

  • Opening a dropdown in the last two rows adds padding between the last row and the bottom of the field
  • Opening a dropdown field NOT in the last two rows does not add padding between the last row and the bottom of the field
  • When "Able to add more rows" is enabled, the text for number of rows (e.g. ("2 out of 4 rows") updates correctly when rows are added and deleted
  • Clicking the delete row button deletes the correct row and maintains the values in all the other rows.
  • The alternating blue/white background for rows is maintained when deleting a row which is not the last row.
  • The table is rendered correctly when there is a mix of optional and required columns.
  • When any required cell is not filled in, attempting to submit the form shows an error at the table field.

Table fields in forms (mobile view)

  • When "Able to add more rows" is enabled, the text for number of rows (e.g. ("2 out of 4 rows") updates correctly when rows are added and deleted
  • Clicking the delete row button deletes the correct row and maintains the values in all the other rows.
  • The alternating blue/white background for rows is maintained when deleting a row which is not the last row.
  • The table is rendered correctly when there is a mix of optional and required columns.
  • When any required cell is not filled in, attempting to submit the form shows an error at the table field.

Nested dropdown field in tables (desktop view)

  • Create a table with multiple nested dropdown columns. Add more than 30 options for the dropdowns. The dropdown should be able to display more than 30 elements when scrolling.
  • Styling should look correct.

Nested dropdown field in tables (mobile view)

  • Create a table with multiple nested dropdown columns. Add more than 30 options for the dropdowns. The dropdown should be able to display more than 30 elements when scrolling.
  • Styling should look correct.

Options for quick copy and paste

Option 1
Option 2
Option 3
Option 4
Option 5
Option 6
Option 7
Option 8
Option 9
Option 10
Option 11
Option 12
Option 13
Option 14
Option 15
Option 16
Option 17
Option 18
Option 19
Option 20
Option 21
Option 22
Option 23
Option 24
Option 25
Option 26
Option 27
Option 28
Option 29
Option 30
Option 31
Option 32
Option 33
Option 34
Option 35

@karrui karrui requested a review from mantariksh December 16, 2020 08:54
@karrui karrui requested a review from tshuli December 16, 2020 09:42
@karrui karrui merged commit 3c74ac5 into release Dec 16, 2020
@liangyuanruo liangyuanruo deleted the release-v4.50.2 branch January 14, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants