-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: release v4.50.2 hotfix #894
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestsAdmin preview for table fields
Table fields in forms (desktop view)
Table fields in forms (mobile view)
Nested dropdown field in tables (desktop view)
Nested dropdown field in tables (mobile view)
Options for quick copy and pasteOption 1 |
no more mobile-desktop divide
karrui
force-pushed
the
release-v4.50.2
branch
from
December 16, 2020 09:05
fad62ec
to
1ac7be6
Compare
liangyuanruo
approved these changes
Dec 16, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.50.2
This hotfix fixes the issue where dropdowns nested inside table fields being limited to only 30 entries. This bug was caused by having two HTML divs housing the same table field with the same dropdown id, resulting in the infinite scroll library only hooking to the desktop variant even on mobile view, resulting in the load more items call to the infinite scroll library not being triggered in mobile.
This is fixed by combining the two containers into a single container and styling it appropriately in both desktop and mobile view.
Fixes
Screenshots
Before
Misaligned columns
Max scroll is 30
After
Aligned table columns
Can infinitely scroll now