Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate controllers and factories to TypeScript and extract services #144

Closed
16 of 20 tasks
liangyuanruo opened this issue Aug 17, 2020 · 1 comment
Closed
16 of 20 tasks

Migrate controllers and factories to TypeScript and extract services #144

liangyuanruo opened this issue Aug 17, 2020 · 1 comment
Assignees
@tshuli
Labels
contribute free for contributors to pick up P2 planned for next 1-2 months reliability
Milestone
typescriptify bac...

Comments

@liangyuanruo
Copy link
Contributor

liangyuanruo commented Aug 17, 2020 •
edited
Loading

Blocked by #22

TODOs

  • Migrate controllers/factories to TypeScript
  • For each controller, extract relevant business logic into services
  • Refactor implementations to use up-to-date patterns where possible e.g. from callbacks to async/await
  • Add new Jest tests, or migrate existing tests from Jasmine to Jest

Controllers

  • admin-console.server.controller.js (@karrui)
  • admin-forms.server.controller.js (@karrui)
  • authentication.server.controller.js (@liangyuanruo)
  • core.server.controller.js (@karrui)
  • email-submissions.server.controller.js (@mantariksh)
  • encrypt-submissions.server.controller.js
  • errors.server.controller.js (@tshuli)
  • myinfo.server.controller.js (@mantariksh )
  • public-forms.server.controller.js (@karrui, 2/6 done. Blocked by spcp server controller refactor)
  • spcp.server.controller.js (@mantariksh)
  • submissions.server.controller.js (@mantariksh)
  • verification.server.controller.js (@mantariksh)
  • webhooks.server.controller.js (@mantariksh)
  • user.server.controller

Factories

  • aggregate-stats.factory.js (@karrui)
  • captcha.factory.js (@karrui)
  • google-analytics.factory.js (@tshuli)
  • sms.factory.js (@karrui)
  • verified-fields.factory.js (@mantariksh)
  • webhook-verified-content.factory.js
@liangyuanruo liangyuanruo mentioned this issue Aug 17, 2020
Closed
@liangyuanruo liangyuanruo added P2 planned for next 1-2 months reliability labels Aug 25, 2020
@karrui karrui mentioned this issue Aug 26, 2020
Merged
13 tasks
@arshadali172 arshadali172 mentioned this issue Sep 1, 2020
Merged
@liangyuanruo liangyuanruo added good first issue help wanted Extra attention is needed contribute free for contributors to pick up and removed help wanted Extra attention is needed labels Sep 8, 2020
@tshuli tshuli mentioned this issue Sep 17, 2020
Closed
This was referenced Sep 30, 2020
Merged
Merged
Merged
This was referenced Oct 1, 2020
Merged
Merged
@arshadali172 arshadali172 removed their assignment Oct 12, 2020
This was referenced Oct 28, 2020
Merged
Merged
This was referenced Nov 9, 2020
Merged
Merged
This was referenced Dec 2, 2020
Merged
Merged
@tshuli tshuli mentioned this issue Dec 15, 2020
Merged
@tshuli tshuli mentioned this issue Dec 16, 2020
Merged
@r00dgirl r00dgirl added this to the typescriptify backend milestone Mar 10, 2021
@karrui karrui mentioned this issue Mar 16, 2021
Closed
@tshuli tshuli mentioned this issue Mar 18, 2021
Merged
3 tasks
@liangyuanruo
Copy link
Contributor Author

Superseded by #1434, #1435, #1437, #1438.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tshuli tshuli

Labels
contribute free for contributors to pick up P2 planned for next 1-2 months reliability
Projects
None yet
Milestone
typescriptify backend
Development

No branches or pull requests
7 participants
@liangyuanruo @LoneRifle @arshadali172 @karrui @mantariksh @r00dgirl @tshuli