Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/core: migrate core controller to TypeScript #788

Merged
merged 7 commits into from
Dec 10, 2020

Conversation

liangyuanruo
Copy link
Contributor

Problem

Addresses #144

Solution

Improvements:

  • Renamed new module to Home to better reflect it's purpose and not pollute the Core
  • Removed unnecessary injection of user into index.view.server.html from req.session

Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also add some integration tests? :P examples are in any of the .routes.spec.ts files

src/app/modules/home/__tests__/home.controller.spec.ts Outdated Show resolved Hide resolved
src/app/modules/home/home.controller.ts Outdated Show resolved Hide resolved
@liangyuanruo
Copy link
Contributor Author

can we also add some integration tests? :P examples are in any of the .routes.spec.ts files

noted but I'd like to prioritise getting this into production. it'll be obvious if it's broken anyway, since the frontend won't load at all.

@liangyuanruo liangyuanruo merged commit bbf3007 into develop Dec 10, 2020
@liangyuanruo liangyuanruo deleted the refactor/core branch December 10, 2020 05:44
@mantariksh mantariksh mentioned this pull request Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants