refactor: migrate frontend routes and google analytics factory to ts #1405
Conversation
|
actually since you're touching the |
tshuli
force-pushed
the
ref/ga-factory
branch
4 times, most recently
from
0e0ffc8 to
0a638df
Compare
tshuli
changed the title
src/loaders/express/index.ts
Outdated
| @@ -147,6 +148,7 @@ const loadExpressApp = async (connection: Connection) => { | |||
| routeFunction(app) | |||
| }) | |||
|
|
|||
| app.use(FrontendRouter) | |||
There was a problem hiding this comment.
can remove the /frontend prefix in frontend.routes and add it here instead
|
@mantariksh thanks for reviewing, for re-review |
| * @returns {String} Current featureManager states | ||
| */ | ||
| export const showFeaturesStates: RequestHandler< | ||
| ParamsDictionary, |
There was a problem hiding this comment.
sorry one more thing, I realised that all these controllers still use the old method of supplying ParamsDictionary as the first generic type argument, which we don't want as per #948. could you help change all of these to unknown pls?
There was a problem hiding this comment.
Ok edited; apart from showFeaturesStates, the rest require ParamsDictionary as the first generic type argument because they call createReqMeta(req) and req is of interface Request which requires ParamsDictionary as the first generic type argument
|
|
||
| interface IGoogleAnalyticsFactory { | ||
| addGoogleAnalyticsData: RequestHandler< | ||
| ParamsDictionary, |
There was a problem hiding this comment.
as above, ParamsDictionary is needed
Problem
Tests
/frontend/environmentendpoint displays the envvars/frontend/featuresendpoint displays the list of features and their activation state