Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: convert errors.server.controller to typescript utility function #602

Merged
merged 15 commits into from
Nov 10, 2020
Merged

refactor: convert errors.server.controller to typescript utility function #602

merged 15 commits into from
Nov 10, 2020

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Nov 9, 2020

Reopens #327
Part of #144

@tshuli tshuli force-pushed the refactor/errors-server-controller branch from b23bb20 to 85e0b5b Compare November 9, 2020 08:26
@tshuli tshuli changed the title refactor: errors.server.controller refactor: convert errors.server.controller to typescript utility function Nov 9, 2020
@tshuli tshuli marked this pull request as ready for review November 9, 2020 11:21
@tshuli tshuli requested a review from karrui November 9, 2020 11:21
@tshuli
Copy link
Contributor Author

tshuli commented Nov 9, 2020

@karrui thanks for your earlier review, the comments were really helpful :)

I've made the edits for your re-review

karrui
karrui approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. Can you create an issue so we can use this utility to generate error strings when creating DatabaseErrors?

something like

return errAsync(
  new DatabaseError(getMongoErrorMessage(error, 'optional default message if needed'))
)

src/app/utils/handle-mongo-error.ts Outdated Show resolved Hide resolved
src/app/utils/handle-mongo-error.ts Show resolved Hide resolved
tshuli added 15 commits November 10, 2020 14:21
@tshuli
chore: rename errors server controller to typescript
21f5f72
@tshuli
chore: add @types/mongodb as devdependency
b69d58d
@tshuli
chore: define MongoError interface
0888531
@tshuli
chore: typescripify errors server controller
208be9f
@tshuli
chore: rename errors server controller spec to ts
ac33a3d
@tshuli
chore: clean up errors.server.controller.spec.ts
b96f1fb
@tshuli
refactor: use destructuring assignment for isEmpty
032a43b
@tshuli
chore: remove types from JSDocs
03e89e7
@tshuli
chore: remove defaultErrorMessage from exports
592de97
@tshuli
chore: remove mongoDuplicateKeyError as only UserSchema has unique ke…
3a3e61b 
…y and that is already validated
@tshuli
refactor: use arrow function for getMongoErrorMessage
db1aa78
@tshuli
refactor: clean up getMongoErrorMessage
0356ff4
@tshuli
chore: shift errors.server.controller to utility function
61de1a0
@tshuli
chore: update tests
65a3bd5
@tshuli
chore: shift defaultErrorMessage to function parameter
42ecda0
@tshuli tshuli force-pushed the refactor/errors-server-controller branch from 85e0b5b to 42ecda0 Compare November 10, 2020 06:21
@tshuli tshuli merged commit 0c9e65d into develop Nov 10, 2020
@tshuli tshuli deleted the refactor/errors-server-controller branch November 10, 2020 11:18
@tshuli tshuli mentioned this pull request Nov 10, 2020
Closed
@karrui karrui mentioned this pull request Nov 17, 2020
Merged
@r00dgirl r00dgirl added this to the typescriptify backend milestone Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrui karrui karrui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
typescriptify backend
Development

Successfully merging this pull request may close these issues.
3 participants
@tshuli @karrui @r00dgirl