-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(4032) - 4156 - Refactor Atlantis countries usage #4163
(4032) - 4156 - Refactor Atlantis countries usage #4163
Conversation
- replace deprecated isAtlantisAllowed with new Areas.isAtlantisAllowed
- Allow Atlantis countries only in non-published cycles
where (ur.cycle_uuid = '${cycle.uuid}' and | ||
ur.assessment_uuid = '${assessment.uuid}') | ||
or ur.role = 'ADMINISTRATOR' | ||
where ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update country user summaries to exclude atlantis roles for published cycles to avoid mismatch in logic
(E.g. FRA2020 -> Admin -> Collaborators: show atlantis country role for user, go to edit user as admin, the role is not visible because we don't allow atlantis countries in published cycles)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't want Atlantis to show up only in public view .
Users with roles should
|
||
import { fields } from './fields' | ||
|
||
const selectFields = fields.map((f) => `u.${f}`).join(',') | ||
|
||
const userRolesSubquery = ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue mentions
line 65: get rid of usersRoleSubquery
But I think it is required if we want to exclude Atlantis roles in published cycles
Let me know
|
@sorja this PR can be merged into 4032 branch if it's ready. what do you think ? |
🛠️ still working on this Need to update the logic, this is the placeholder PR only:
|
Resolves #4156