Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Atlantis countries usage #4156

Open
minotogna opened this issue Nov 28, 2024 · 1 comment · May be fixed by #4053
Open

Refactor Atlantis countries usage #4156

minotogna opened this issue Nov 28, 2024 · 1 comment · May be fixed by #4053
Assignees
Labels
enhancement New feature or request refactor Code quality improvement
Milestone

Comments

@minotogna
Copy link
Member

minotogna commented Nov 28, 2024

  • Atlantis countries must be hidden only in published public view cycles .
  • Not available in published public view cycles
  • Remove env variable FRA_ATLANTIS_ALLOWED (locally, env template, and heroku after deploy)
  • make sure fra all cycles have country Atlantis views
  • in src/server/repository/public/user/getOne.ts
    • remove allowedCountriesOnly prop (it is always true because it never gets invoked with allowedCountriesOnly=false)
    • line 65: get rid of usersRoleSubquery

e.g. fra 2020 should hide them.

  • check db fetch .
  • check env
@minotogna minotogna added this to the 3.6.4 milestone Nov 28, 2024
@minotogna minotogna added enhancement New feature or request refactor Code quality improvement labels Nov 28, 2024
@sorja
Copy link
Contributor

sorja commented Nov 29, 2024

@minotogna We can also explore the option to delete Atlantis countries completely from published cycles (discussion)

I will implement: if cycle.ispublished = no antlantis countries

Let me know

@sorja sorja linked a pull request Nov 29, 2024 that will close this issue
1 task
@minotogna minotogna modified the milestones: 3.6.4, 3.7.0 Dec 9, 2024
@minotogna minotogna linked a pull request Dec 13, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Code quality improvement
Projects
None yet
2 participants