-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(4032) - 4156 - Refactor Atlantis countries usage #4163
Closed
sorja
wants to merge
6
commits into
4032-split-user-role-invitation
from
4032-4156-refactor-atlantis-countries-usage
Closed
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e07d68d
4156 - Areas: Introduce isAtlantisAllowed and const ATLANTIS_PREFIX
sorja 5556614
4156 - Remove FRA_ATLANTIS_ALLOWED and fraAtlantisAllowed
sorja 3c174d3
4156 - country_user_summary exclude atlantis roles in published cycles
sorja 855066f
4156 - use Areas.isAtlantisAllowed
sorja 2e35fc2
4156 - users/getOne: Update role filtering for Atlantis countries
sorja 913fe8c
4156 - remove deprecation notice
sorja File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4156 - country_user_summary exclude atlantis roles in published cycles
- Loading branch information
commit 3c174d3ea0d21d46809c05e6c38d0220f9dad6f9
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update country user summaries to exclude atlantis roles for published cycles to avoid mismatch in logic
(E.g. FRA2020 -> Admin -> Collaborators: show atlantis country role for user, go to edit user as admin, the role is not visible because we don't allow atlantis countries in published cycles)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't want Atlantis to show up only in public view .
Users with roles should