fix: toggle report missing settings #337
Conversation
Adds missing settings to the toggle report. #310
| @@ -14,6 +14,11 @@ Change Log | |||
| Unreleased | |||
| ~~~~~~~~~~ | |||
|
|
|||
| [5.1.1] - 2024-01-31 | |||
There was a problem hiding this comment.
Remember to bump the version in code as well.
There was a problem hiding this comment.
Someone already updated the version here:
edx-toggles/edx_toggles/__init__.py
Line 5 in c9ed5b0
But it was never released: https://pypi.org/project/edx-toggles/
| @@ -213,7 +213,14 @@ def _add_settings(settings_dict): | |||
| """ | |||
| Fill the `settings_dict`: will only include values that are set to true or false. | |||
| """ | |||
| for setting_name, setting_value in vars(settings).items(): | |||
There was a problem hiding this comment.
Was the issue that vars just doesn't work at all with the settings object?
There was a problem hiding this comment.
It works, but only for settings that were previously requested. So if I set a new test setting, and then if I retrieve that setting in middleware, before the view that uses this report, then it starts appearing. I imagine this is due to lazy loading of settings.
There was a problem hiding this comment.
Note: I did ensure that the new test I added failed without the fix.
There was a problem hiding this comment.
Ah, very interesting. And that makes sense.
Description:
Adds missing settings to the toggle report.
Fixes #310
Merge checklist:
Post merge:
finished.