fix: toggle report missing settings (#337)

Adds missing settings to the toggle report.

#310

CHANGELOG.rst

@@ -14,6 +14,11 @@ Change Log
 Unreleased
 ~~~~~~~~~~
 
+[5.1.1] - 2024-01-31
+--------------------
+
+* Fix toggle report to output all settings.
+
 [5.1.0] - 2023-08-02
 --------------------
 

edx_toggles/tests/test_state.py

@@ -33,6 +33,26 @@ def test_response_with_waffle_switch(self):
         waffle_names = [waffle["name"] for waffle in report["waffle_switches"]]
         self.assertIn("test.switch", waffle_names)
 
+    def test_response_with_simple_setting(self):
+        with override_settings(MYSETTING=True):
+            report = ToggleStateReport().as_dict()
+
+        self.assertIn(
+            {
+                "name": "MYSETTING",
+                "is_active": True,
+            },
+            report["django_settings"],
+        )
+
+        self.assertNotIn(
+            {
+                "name": "__dict__['MYSETTING']",
+                "is_active": True,
+            },
+            report["django_settings"],
+        )
+
     def test_response_with_setting_toggle(self):
         _toggle = SettingToggle("MYSETTING", default=False, module_name="module1")
         with override_settings(MYSETTING=True):

edx_toggles/toggles/state/internal/report.py

@@ -213,7 +213,14 @@ def _add_settings(settings_dict):
     """
     Fill the `settings_dict`: will only include values that are set to true or false.
     """
-    for setting_name, setting_value in vars(settings).items():
+    settings_dict_copy = {}
+    default_attribute_value = object()  # default is not a bool, so won't be included
+    for attr in dir(settings):
+        if not attr.startswith('__'):
+            value = getattr(settings, attr, default_attribute_value)
+            settings_dict_copy[attr] = value
+
+    for setting_name, setting_value in settings_dict_copy.items():
         if isinstance(setting_value, dict):
             for dict_name, dict_value in setting_value.items():
                 if isinstance(dict_value, bool):