Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible issue with edx-platform toggle report #310

Closed
robrap opened this issue Sep 11, 2023 · 2 comments · Fixed by #337
Closed

Possible issue with edx-platform toggle report #310

robrap opened this issue Sep 11, 2023 · 2 comments · Fixed by #337
Assignees

Comments

@robrap
Copy link
Contributor

robrap commented Sep 11, 2023

At edx.org, we saw several discrepancies between our private settings (edx-internal) and the toggles reported in https://courses.edx.org/api/toggles/v0/state/.

As an example, the setting ENABLE_DEMOGRAPHICS_COLLECTION is set in edx-internals, and yet did not appear in the report. Additionally, another toggle that was being rolled out in Stage did not appear in the report. Note that the two examples seen were top-level toggles (i.e. were not a part of a dict).

It has not been confirmed that these settings appear on the actual boxes, in which case the report may be fine and there might be some other issue in deploying settings. However, if the settings are found on the box, it may be that there is a problem generating the report itself.

@robrap robrap added this to Arch-BOM Sep 11, 2023
@robrap
Copy link
Contributor Author

robrap commented Sep 11, 2023

@rgraber: Are you able to get on to Stage boxes to confirm, or would SRE need to be involved? (Note: this has not been prioritized, but it was disconcerting when I was trying to rely on this report for deployment.)

@robrap robrap added the esre Embedded SRE label Sep 18, 2023
robrap added a commit that referenced this issue Jan 31, 2024
Adds missing settings to the toggle report.

#310
@robrap robrap self-assigned this Jan 31, 2024
@robrap robrap moved this to In Progress in Arch-BOM Jan 31, 2024
@robrap robrap removed the esre Embedded SRE label Jan 31, 2024
@robrap
Copy link
Contributor Author

robrap commented Jan 31, 2024

I found the issue and am fixing it in this PR: #337

robrap added a commit that referenced this issue Jan 31, 2024
Adds missing settings to the toggle report.

#310
@github-project-automation github-project-automation bot moved this from In Progress to Done in Arch-BOM Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant