feat: Pin python3-saml again for duplicate attributes issue #32328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're seeing an issue with repeated attributes causing auth failure for some IdPs, and need to take some time to investigate. See unpinning issue #32327 for details. This is expected to reintroduce some bugs in testing SAML in devstack. This has the effect of reverting the following PRs: - Unpinned: #32167 (partial) - Upgraded: #32168 However, we're keeping the safe_lxml adjustments from the first PR, so it should be fine on that front to re-upgrade whenever we're ready.
johnnagro
approved these changes
May 30, 2023
| @@ -101,3 +101,11 @@ urllib3<2.0.0 | |||
| # Sphinx==5.3.0 requires docutils<0.20 | |||
| # Issue to unpin Sphinx to resolve this constraint: https://github.com/openedx/edx-lint/issues/338 | |||
| docutils<0.20 | |||
|
|
|||
| # When we unpinned python3-saml and allowed it to upgrade from 1.9.0 | |||
There was a problem hiding this comment.
great comment to leave here, thank you.
matthugs
approved these changes
May 30, 2023
|
surfacing that there was concern about compatibility with the social-core library's version, but our current working hypothesis is that this version should work with current social-core. If there are further issues we'll need to revisit that hypothesis & maybe tweak versions to find a compatible pair, but for right now this is a worthy experiment for resolving the immediate issue. |
|
Context for this PR can be found in this ticket: MST-1916. |
schenedx
approved these changes
May 30, 2023
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
Yagnesh1998
pushed a commit
to ManpraXSoftware/edx-platform
that referenced
this pull request
Jun 8, 2023
…32328) We're seeing an issue with repeated attributes causing auth failure for some IdPs, and need to take some time to investigate. See unpinning issue openedx#32327 for details. This is expected to reintroduce some bugs in testing SAML in devstack. This has the effect of reverting the following PRs: - Unpinned: openedx#32167 (partial) - Upgraded: openedx#32168 However, we're keeping the safe_lxml adjustments from the first PR, so it should be fine on that front to re-upgrade whenever we're ready.
Yagnesh1998
pushed a commit
to ManpraXSoftware/edx-platform
that referenced
this pull request
Jun 8, 2023
…32328) We're seeing an issue with repeated attributes causing auth failure for some IdPs, and need to take some time to investigate. See unpinning issue openedx#32327 for details. This is expected to reintroduce some bugs in testing SAML in devstack. This has the effect of reverting the following PRs: - Unpinned: openedx#32167 (partial) - Upgraded: openedx#32168 However, we're keeping the safe_lxml adjustments from the first PR, so it should be fine on that front to re-upgrade whenever we're ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing an issue with repeated attributes causing auth failure for some IdPs, and need to take some time to investigate. See unpinning issue #32327 for details.
This is expected to reintroduce some bugs in testing SAML in devstack.
This has the effect of reverting the following PRs:
However, we're keeping the safe_lxml adjustments from the first PR, so it should be fine on that front to re-upgrade whenever we're ready.